From 65d5306316ba930c67940fc499c8260f5c007806 Mon Sep 17 00:00:00 2001
From: jcoux <julien.coux@camptocamp.com>
Date: Fri, 29 Jul 2016 15:01:48 +0200
Subject: [PATCH] Global review, fix and make missing fields translatable

---
 .../report/aged_partner_balance.py            | 18 +++++++------
 .../report/general_ledger.py                  |  4 ++-
 .../report/open_items.py                      |  2 ++
 .../report/trial_balance.py                   | 10 ++++---
 .../wizard/aged_partner_balance_wizard.py     |  3 ++-
 .../aged_partner_balance_wizard_view.xml      | 24 ++++++++---------
 .../wizard/general_ledger_wizard.py           |  9 +++++--
 .../wizard/general_ledger_wizard_view.xml     | 26 +++++++++----------
 .../wizard/open_items_wizard.py               |  3 ++-
 .../wizard/open_items_wizard_view.xml         | 24 ++++++++---------
 .../wizard/trial_balance_wizard.py            |  9 +++++--
 .../wizard/trial_balance_wizard_view.xml      | 24 ++++++++---------
 12 files changed, 84 insertions(+), 72 deletions(-)

diff --git a/account_financial_report_qweb/report/aged_partner_balance.py b/account_financial_report_qweb/report/aged_partner_balance.py
index 3fe45ce4..190dea53 100644
--- a/account_financial_report_qweb/report/aged_partner_balance.py
+++ b/account_financial_report_qweb/report/aged_partner_balance.py
@@ -11,10 +11,10 @@ class AgedPartnerBalanceReport(models.TransientModel):
 
     The class hierarchy is :
     * AgedPartnerBalanceReport
-    ** AgedPartnerBalanceAccount
-    *** AgedPartnerBalancePartner
-    **** AgedPartnerBalanceLine
-    **** AgedPartnerBalanceMoveLine
+    ** AgedPartnerBalanceReportAccount
+    *** AgedPartnerBalanceReportPartner
+    **** AgedPartnerBalanceReportLine
+    **** AgedPartnerBalanceReportMoveLine
             If "show_move_line_details" is selected
     """
 
@@ -38,7 +38,7 @@ class AgedPartnerBalanceReport(models.TransientModel):
     )
 
 
-class AgedPartnerBalanceAccount(models.TransientModel):
+class AgedPartnerBalanceReportAccount(models.TransientModel):
 
     _name = 'report_aged_partner_balance_qweb_account'
     _order = 'code ASC'
@@ -81,7 +81,7 @@ class AgedPartnerBalanceAccount(models.TransientModel):
     )
 
 
-class AgedPartnerBalancePartner(models.TransientModel):
+class AgedPartnerBalanceReportPartner(models.TransientModel):
 
     _name = 'report_aged_partner_balance_qweb_partner'
 
@@ -125,7 +125,7 @@ ORDER BY
         """
 
 
-class AgedPartnerBalanceLine(models.TransientModel):
+class AgedPartnerBalanceReportLine(models.TransientModel):
 
     _name = 'report_aged_partner_balance_qweb_line'
 
@@ -146,7 +146,7 @@ class AgedPartnerBalanceLine(models.TransientModel):
     older = fields.Float(digits=(16, 2))
 
 
-class AgedPartnerBalanceMoveLine(models.TransientModel):
+class AgedPartnerBalanceReportMoveLine(models.TransientModel):
 
     _name = 'report_aged_partner_balance_qweb_move_line'
 
@@ -222,6 +222,8 @@ class AgedPartnerBalanceReportCompute(models.TransientModel):
             self._inject_move_line_values()
             self._inject_move_line_values(only_empty_partner_line=True)
         self._compute_accounts_cumul()
+        # Refresh cache because all data are computed with SQL requests
+        self.refresh()
 
     def _inject_account_values(self):
         """Inject report values for report_aged_partner_balance_qweb_account"""
diff --git a/account_financial_report_qweb/report/general_ledger.py b/account_financial_report_qweb/report/general_ledger.py
index 3c9524fd..035cc4de 100644
--- a/account_financial_report_qweb/report/general_ledger.py
+++ b/account_financial_report_qweb/report/general_ledger.py
@@ -208,6 +208,8 @@ class GeneralLedgerReportCompute(models.TransientModel):
             self._inject_line_centralized_values()
         # Compute display flag
         self._compute_has_second_currency()
+        # Refresh cache because all data are computed with SQL requests
+        self.refresh()
 
     def _inject_account_values(self):
         """Inject report values for report_general_ledger_qweb_account."""
@@ -896,7 +898,7 @@ SELECT
     NOW() AS create_date,
     ml.date,
     a.code AS account,
-    'Centralized Entries' AS label,
+    '""" + _('Centralized Entries') + """' AS label,
     ml.debit AS debit,
     ml.credit AS credit,
     ra.initial_balance + (
diff --git a/account_financial_report_qweb/report/open_items.py b/account_financial_report_qweb/report/open_items.py
index 9488deb0..ba82ddbf 100644
--- a/account_financial_report_qweb/report/open_items.py
+++ b/account_financial_report_qweb/report/open_items.py
@@ -169,6 +169,8 @@ class OpenItemsReportCompute(models.TransientModel):
             )
         # Compute display flag
         self._compute_has_second_currency()
+        # Refresh cache because all data are computed with SQL requests
+        self.refresh()
 
     def _inject_account_values(self):
         """Inject report values for report_open_items_qweb_account."""
diff --git a/account_financial_report_qweb/report/trial_balance.py b/account_financial_report_qweb/report/trial_balance.py
index 5073d25a..788ae71b 100644
--- a/account_financial_report_qweb/report/trial_balance.py
+++ b/account_financial_report_qweb/report/trial_balance.py
@@ -11,8 +11,8 @@ class TrialBalanceReport(models.TransientModel):
 
     The class hierarchy is :
     * TrialBalanceReport
-    ** TrialBalanceAccount
-    *** TrialBalancePartner
+    ** TrialBalanceReportAccount
+    *** TrialBalanceReportPartner
             If "show_partner_details" is selected
     """
 
@@ -42,7 +42,7 @@ class TrialBalanceReport(models.TransientModel):
     )
 
 
-class TrialBalanceAccount(models.TransientModel):
+class TrialBalanceReportAccount(models.TransientModel):
 
     _name = 'report_trial_balance_qweb_account'
     _order = 'code ASC'
@@ -75,7 +75,7 @@ class TrialBalanceAccount(models.TransientModel):
     )
 
 
-class TrialPartnerAccount(models.TransientModel):
+class TrialBalanceReportPartner(models.TransientModel):
 
     _name = 'report_trial_balance_qweb_partner'
 
@@ -156,6 +156,8 @@ class TrialBalanceReportCompute(models.TransientModel):
         self._inject_account_values()
         if self.show_partner_details:
             self._inject_partner_values()
+        # Refresh cache because all data are computed with SQL requests
+        self.refresh()
 
     def _inject_account_values(self):
         """Inject report values for report_trial_balance_qweb_account"""
diff --git a/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py b/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py
index 8bc9c121..3dfd7852 100644
--- a/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py
+++ b/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py
@@ -16,7 +16,8 @@ class AgedPartnerBalance(models.TransientModel):
 
     company_id = fields.Many2one(
         comodel_name='res.company',
-        default=lambda self: self.env.user.company_id
+        default=lambda self: self.env.user.company_id,
+        string='Company'
     )
     date_at = fields.Date(required=True,
                           default=fields.Date.to_string(datetime.today()))
diff --git a/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml b/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml
index be180406..8d6c611a 100644
--- a/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml
@@ -8,10 +8,10 @@
         <field name="arch" type="xml">
             <form>
                 <group name="main_info">
-                    <field name="company_id" groups="base.group_multi_company"/>
+                    <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                 </group>
                 <group name="filters">
-                    <group name="date_ranger">
+                    <group name="date_range">
                         <field name="date_at"/>
                     </group>
                     <group name="other_filters">
@@ -20,14 +20,14 @@
                     </group>
                 </group>
                 <label for="partner_ids"/>
-                <field name="partner_ids" nolabel="1"/>
+                <field name="partner_ids" nolabel="1" options="{'no_create': True}"/>
                 <group/>
                 <label for="account_ids"/>
                 <group col="4">
                     <field name="receivable_accounts_only"/>
                     <field name="payable_accounts_only"/>
                 </group>
-                <field name="account_ids" nolabel="1"/>
+                <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 <footer>
                     <button name="button_export_pdf" string="Export PDF" type="object" default_focus="1" class="oe_highlight"/>
                     or
@@ -39,14 +39,12 @@
         </field>
     </record>
 
-    <record id="action_aged_partner_balance_wizard" model="ir.actions.act_window">
-        <field name="name">Aged Partner Balance</field>
-        <field name="type">ir.actions.act_window</field>
-        <field name="res_model">aged.partner.balance.wizard</field>
-        <field name="view_type">form</field>
-        <field name="view_mode">form</field>
-        <field name="view_id" ref="aged_partner_balance_wizard"/>
-        <field name="target">new</field>
-    </record>
+    <act_window id="action_aged_partner_balance_wizard"
+                name="Aged Partner Balance"
+                res_model="aged.partner.balance.wizard"
+                view_type="form"
+                view_mode="form"
+                view_id="aged_partner_balance_wizard"
+                target="new" />
 
 </odoo>
diff --git a/account_financial_report_qweb/wizard/general_ledger_wizard.py b/account_financial_report_qweb/wizard/general_ledger_wizard.py
index e786d997..3a2cda32 100644
--- a/account_financial_report_qweb/wizard/general_ledger_wizard.py
+++ b/account_financial_report_qweb/wizard/general_ledger_wizard.py
@@ -15,9 +15,14 @@ class GeneralLedgerReportWizard(models.TransientModel):
 
     company_id = fields.Many2one(
         comodel_name='res.company',
-        default=lambda self: self.env.user.company_id
+        default=lambda self: self.env.user.company_id,
+        string='Company'
+    )
+    date_range_id = fields.Many2one(
+        comodel_name='date.range',
+        required=True,
+        string='Date range'
     )
-    date_range_id = fields.Many2one(comodel_name='date.range', required=True)
     date_from = fields.Date(required=True)
     date_to = fields.Date(required=True)
     fy_start_date = fields.Date(required=True)
diff --git a/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml b/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml
index 52250300..dff93e5a 100644
--- a/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml
@@ -8,10 +8,10 @@
         <field name="arch" type="xml">
             <form>
                 <group name="main_info">
-                    <field name="company_id" groups="base.group_multi_company"/>
+                    <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                 </group>
                 <group name="filters">
-                    <group name="date_ranger">
+                    <group name="date_range">
                         <field name="date_range_id" domain="[('company_id','=',company_id)]"/>
                         <field name="date_from"/>
                         <field name="date_to"/>
@@ -24,17 +24,17 @@
                     </group>
                 </group>
                 <label for="cost_center_ids" groups="analytic.group_analytic_accounting"/>
-                <field name="cost_center_ids" nolabel="1" groups="analytic.group_analytic_accounting"/>
+                <field name="cost_center_ids" nolabel="1" options="{'no_create': True}" groups="analytic.group_analytic_accounting"/>
                 <group/>
                 <label for="partner_ids"/>
-                <field name="partner_ids" nolabel="1"/>
+                <field name="partner_ids" nolabel="1" options="{'no_create': True}"/>
                 <group/>
                 <label for="account_ids"/>
                 <group col="4">
                     <field name="receivable_accounts_only"/>
                     <field name="payable_accounts_only"/>
                 </group>
-                <field name="account_ids" nolabel="1"/>
+                <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 <footer>
                     <button name="button_export_pdf" string="Export PDF" type="object" default_focus="1" class="oe_highlight"/>
                     or
@@ -46,14 +46,12 @@
         </field>
     </record>
 
-    <record id="action_general_ledger_wizard" model="ir.actions.act_window">
-        <field name="name">General Ledger</field>
-        <field name="type">ir.actions.act_window</field>
-        <field name="res_model">general.ledger.report.wizard</field>
-        <field name="view_type">form</field>
-        <field name="view_mode">form</field>
-        <field name="view_id" ref="general_ledger_wizard"/>
-        <field name="target">new</field>
-    </record>
+    <act_window id="action_general_ledger_wizard"
+                name="General Ledger"
+                res_model="general.ledger.report.wizard"
+                view_type="form"
+                view_mode="form"
+                view_id="general_ledger_wizard"
+                target="new" />
 
 </odoo>
diff --git a/account_financial_report_qweb/wizard/open_items_wizard.py b/account_financial_report_qweb/wizard/open_items_wizard.py
index 4a089ac5..2f921a8c 100644
--- a/account_financial_report_qweb/wizard/open_items_wizard.py
+++ b/account_financial_report_qweb/wizard/open_items_wizard.py
@@ -16,7 +16,8 @@ class OpenItemsReportWizard(models.TransientModel):
 
     company_id = fields.Many2one(
         comodel_name='res.company',
-        default=lambda self: self.env.user.company_id
+        default=lambda self: self.env.user.company_id,
+        string='Company'
     )
     date_at = fields.Date(required=True,
                           default=fields.Date.to_string(datetime.today()))
diff --git a/account_financial_report_qweb/wizard/open_items_wizard_view.xml b/account_financial_report_qweb/wizard/open_items_wizard_view.xml
index 7aced656..6b9c3ea7 100644
--- a/account_financial_report_qweb/wizard/open_items_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/open_items_wizard_view.xml
@@ -8,10 +8,10 @@
         <field name="arch" type="xml">
             <form>
                 <group name="main_info">
-                    <field name="company_id" groups="base.group_multi_company"/>
+                    <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                 </group>
                 <group name="filters">
-                    <group name="date_ranger">
+                    <group name="date_range">
                         <field name="date_at"/>
                     </group>
                     <group name="other_filters">
@@ -20,14 +20,14 @@
                     </group>
                 </group>
                 <label for="partner_ids"/>
-                <field name="partner_ids" nolabel="1"/>
+                <field name="partner_ids" nolabel="1" options="{'no_create': True}"/>
                 <group/>
                 <label for="account_ids"/>
                 <group col="4">
                     <field name="receivable_accounts_only"/>
                     <field name="payable_accounts_only"/>
                 </group>
-                <field name="account_ids" nolabel="1"/>
+                <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 <footer>
                     <button name="button_export_pdf" string="Export PDF" type="object" default_focus="1" class="oe_highlight"/>
                     or
@@ -39,14 +39,12 @@
         </field>
     </record>
 
-    <record id="action_open_items_wizard" model="ir.actions.act_window">
-        <field name="name">Open Items</field>
-        <field name="type">ir.actions.act_window</field>
-        <field name="res_model">open.items.report.wizard</field>
-        <field name="view_type">form</field>
-        <field name="view_mode">form</field>
-        <field name="view_id" ref="open_items_wizard"/>
-        <field name="target">new</field>
-    </record>
+    <act_window id="action_open_items_wizard"
+                name="Open Items"
+                res_model="open.items.report.wizard"
+                view_type="form"
+                view_mode="form"
+                view_id="open_items_wizard"
+                target="new" />
 
 </odoo>
diff --git a/account_financial_report_qweb/wizard/trial_balance_wizard.py b/account_financial_report_qweb/wizard/trial_balance_wizard.py
index e8e7c7c5..0c1e7dae 100644
--- a/account_financial_report_qweb/wizard/trial_balance_wizard.py
+++ b/account_financial_report_qweb/wizard/trial_balance_wizard.py
@@ -14,9 +14,14 @@ class TrialBalanceReportWizard(models.TransientModel):
 
     company_id = fields.Many2one(
         comodel_name='res.company',
-        default=lambda self: self.env.user.company_id
+        default=lambda self: self.env.user.company_id,
+        string='Company'
+    )
+    date_range_id = fields.Many2one(
+        comodel_name='date.range',
+        required=True,
+        string='Date range'
     )
-    date_range_id = fields.Many2one(comodel_name='date.range', required=True)
     date_from = fields.Date(required=True)
     date_to = fields.Date(required=True)
     fy_start_date = fields.Date(required=True)
diff --git a/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml b/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml
index 4be91296..db7be23e 100644
--- a/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml
@@ -8,10 +8,10 @@
         <field name="arch" type="xml">
             <form>
                 <group name="main_info">
-                    <field name="company_id" groups="base.group_multi_company"/>
+                    <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                 </group>
                 <group name="filters">
-                    <group name="date_ranger">
+                    <group name="date_range">
                         <field name="date_range_id" domain="[('company_id','=',company_id)]"/>
                         <field name="date_from"/>
                         <field name="date_to"/>
@@ -24,14 +24,14 @@
                     </group>
                 </group>
                 <label for="partner_ids" attrs="{'invisible':[('show_partner_details','!=',True)]}"/>
-                <field name="partner_ids" nolabel="1" attrs="{'invisible':[('show_partner_details','!=',True)]}"/>
+                <field name="partner_ids" nolabel="1" options="{'no_create': True}" attrs="{'invisible':[('show_partner_details','!=',True)]}"/>
                 <group attrs="{'invisible':[('show_partner_details','!=',True)]}"/>
                 <label for="account_ids"/>
                 <group col="4">
                     <field name="receivable_accounts_only"/>
                     <field name="payable_accounts_only"/>
                 </group>
-                <field name="account_ids" nolabel="1"/>
+                <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 <footer>
                     <button name="button_export_pdf" string="Export PDF" type="object" default_focus="1" class="oe_highlight"/>
                     or
@@ -43,14 +43,12 @@
         </field>
     </record>
 
-    <record id="action_trial_balance_wizard" model="ir.actions.act_window">
-        <field name="name">Trial Balance</field>
-        <field name="type">ir.actions.act_window</field>
-        <field name="res_model">trial.balance.report.wizard</field>
-        <field name="view_type">form</field>
-        <field name="view_mode">form</field>
-        <field name="view_id" ref="trial_balance_wizard"/>
-        <field name="target">new</field>
-    </record>
+    <act_window id="action_trial_balance_wizard"
+                name="Trial Balance"
+                res_model="trial.balance.report.wizard"
+                view_type="form"
+                view_mode="form"
+                view_id="trial_balance_wizard"
+                target="new" />
 
 </odoo>