From f5ff2eb49a43a20900edc2ddca4c0a2fca998fd5 Mon Sep 17 00:00:00 2001
From: Tonow-c2c <thomas.nowicki@camptocamp.com>
Date: Thu, 27 Jun 2019 08:45:18 +0200
Subject: [PATCH] [11.0][account_financial_report] Fix report name test

---
 account_financial_report/report/general_ledger.py   |  5 ++++-
 .../report/templates/general_ledger.xml             |  4 ++++
 account_financial_report/reports.xml                | 10 +++++-----
 account_financial_report/tests/abstract_test.py     | 13 ++++++++++---
 .../tests/test_general_ledger.py                    |  3 +++
 5 files changed, 26 insertions(+), 9 deletions(-)

diff --git a/account_financial_report/report/general_ledger.py b/account_financial_report/report/general_ledger.py
index db6512f3..5af9f600 100644
--- a/account_financial_report/report/general_ledger.py
+++ b/account_financial_report/report/general_ledger.py
@@ -219,6 +219,9 @@ class GeneralLedgerReportCompute(models.TransientModel):
         self.ensure_one()
         if report_type == 'xlsx':
             report_name = 'a_f_r.report_general_ledger_xlsx'
+        elif report_type == 'qweb-html':
+            report_name = 'account_financial_report.' \
+                          'report_general_ledger_html_qweb'
         else:
             report_name = 'account_financial_report.' \
                           'report_general_ledger_qweb'
@@ -1224,7 +1227,7 @@ LEFT JOIN
     account_analytic_account aa ON ml.analytic_account_id = aa.id
             """
         if self.filter_analytic_tag_ids:
-                query_inject_move_line += """
+            query_inject_move_line += """
         INNER JOIN
             move_lines_on_tags ON ml.id = move_lines_on_tags.ml_id
                     """
diff --git a/account_financial_report/report/templates/general_ledger.xml b/account_financial_report/report/templates/general_ledger.xml
index ff03ca33..9506a3ca 100644
--- a/account_financial_report/report/templates/general_ledger.xml
+++ b/account_financial_report/report/templates/general_ledger.xml
@@ -11,6 +11,10 @@
         </t>
     </template>
 
+    <template id="report_general_ledger_html_qweb">
+        <t t-call="account_financial_report.report_general_ledger_qweb"/>
+    </template>
+
     <template id="report_general_ledger_base">
         <!-- Saved flag fields into variables, used to define columns display -->
         <t t-set="show_analytic_tags" t-value="o.show_analytic_tags"/>
diff --git a/account_financial_report/reports.xml b/account_financial_report/reports.xml
index 2cb2ffd3..e9b05ebd 100644
--- a/account_financial_report/reports.xml
+++ b/account_financial_report/reports.xml
@@ -17,10 +17,10 @@
       model="report_general_ledger"
       string="General Ledger"
       report_type="qweb-html"
-      name="account_financial_report.report_general_ledger_qweb"
+      name="account_financial_report.report_general_ledger_html_qweb"
       file="account_financial_report.report_general_ledger_html"
       />
-    
+
     <!-- Journal Ledger -->
     <report
       id="action_report_journal_ledger_qweb"
@@ -110,7 +110,7 @@
       name="account_financial_report.report_vat_report_qweb"
       file="account_financial_report.report_vat_report_html"
     />
-    
+
     <!-- PDF REPORTS : paperformat -->
 
     <record id="report_qweb_paperformat" model="report.paperformat">
@@ -145,7 +145,7 @@
             model="ir.actions.report">
         <field name="paperformat_id" ref="report_qweb_paperformat"/>
     </record>
-    
+
     <record id="action_report_vat_report_qweb"
             model="ir.actions.report">
         <field name="paperformat_id" ref="report_qweb_paperformat"/>
@@ -197,7 +197,7 @@
         <field name="report_type">xlsx</field>
         <field name="report_file">report_aged_partner_balance</field>
     </record>
-    
+
     <record id="action_report_vat_report_xlsx" model="ir.actions.report">
         <field name="name">VAT Report XLSX</field>
         <field name="model">report_vat_report</field>
diff --git a/account_financial_report/tests/abstract_test.py b/account_financial_report/tests/abstract_test.py
index 5935a59f..66a80f61 100644
--- a/account_financial_report/tests/abstract_test.py
+++ b/account_financial_report/tests/abstract_test.py
@@ -213,6 +213,7 @@ class AbstractTest(common.TransactionCase):
         self.model = self._getReportModel()
 
         self.qweb_report_name = self._getQwebReportName()
+        self.html_report_name = self._getHtmlReportName()
         self.xlsx_report_name = self._getXlsxReportName()
         self.xlsx_action_name = self._getXlsxReportActionName()
 
@@ -226,7 +227,7 @@ class AbstractTest(common.TransactionCase):
 
     def test_html(self):
         test_reports.try_report(self.env.cr, self.env.uid,
-                                self.qweb_report_name,
+                                self.html_report_name,
                                 [self.report.id],
                                 report_type='qweb-html')
 
@@ -255,7 +256,7 @@ class AbstractTest(common.TransactionCase):
         self.assertDictContainsSubset(
             {
                 'type': 'ir.actions.report',
-                'report_name': self.qweb_report_name,
+                'report_name': self.html_report_name,
                 'report_type': 'qweb-html',
             },
             report_action
@@ -263,7 +264,7 @@ class AbstractTest(common.TransactionCase):
 
         # Check if report template is correct
         report = self.env['ir.actions.report'].search(
-            [('report_name', '=', self.qweb_report_name),
+            [('report_name', '=', self.html_report_name),
              ('report_type', '=', report_type)], limit=1)
         self.assertEqual(report.report_type, 'qweb-html')
 
@@ -377,6 +378,12 @@ class AbstractTest(common.TransactionCase):
         """
         raise NotImplementedError()
 
+    def _getHtmlReportName(self):
+        """
+            :return: the html report name
+        """
+        raise NotImplementedError()
+
     def _getXlsxReportName(self):
         """
             :return: the xlsx report name
diff --git a/account_financial_report/tests/test_general_ledger.py b/account_financial_report/tests/test_general_ledger.py
index ca218b91..95328ba9 100644
--- a/account_financial_report/tests/test_general_ledger.py
+++ b/account_financial_report/tests/test_general_ledger.py
@@ -19,6 +19,9 @@ class TestGeneralLedger(a_t_f_c.AbstractTestForeignCurrency):
     def _getQwebReportName(self):
         return 'account_financial_report.report_general_ledger_qweb'
 
+    def _getHtmlReportName(self):
+        return 'account_financial_report.report_general_ledger_html_qweb'
+
     def _getXlsxReportName(self):
         return 'a_f_r.report_general_ledger_xlsx'