From faa829e789a480d9b381dc957bdc3de10d4fc41d Mon Sep 17 00:00:00 2001
From: Alexis de Lattre <alexis.delattre@akretion.com>
Date: Wed, 5 Sep 2018 11:20:23 +0200
Subject: [PATCH] Improve workaround for bug
 https://github.com/odoo/odoo/issues/14761

It replaces the workaround widget="many2many_tags" on field name="account_ids" which prevented from selecting several accounts at the same time (quite useful when you want to select an interval of accounts for example). We now use the regular M2M widget and inherit create()
---
 .../wizard/aged_partner_balance_wizard.py     | 21 +++++++++++++++++++
 .../aged_partner_balance_wizard_view.xml      |  2 +-
 .../wizard/general_ledger_wizard.py           | 21 +++++++++++++++++++
 .../wizard/general_ledger_wizard_view.xml     |  2 +-
 .../wizard/open_items_wizard.py               | 21 +++++++++++++++++++
 .../wizard/open_items_wizard_view.xml         |  2 +-
 .../wizard/trial_balance_wizard.py            | 21 +++++++++++++++++++
 .../wizard/trial_balance_wizard_view.xml      |  2 +-
 8 files changed, 88 insertions(+), 4 deletions(-)

diff --git a/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py b/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py
index 6e7e135e..934e66f1 100644
--- a/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py
+++ b/account_financial_report_qweb/wizard/aged_partner_balance_wizard.py
@@ -54,6 +54,27 @@ class AgedPartnerBalance(models.TransientModel):
         else:
             self.account_ids = None
 
+    @api.model
+    def create(self, vals):
+        """
+        This is a workaround for bug https://github.com/odoo/odoo/issues/14761
+        This bug impacts M2M fields in wizards filled-up via onchange
+        It replaces the workaround widget="many2many_tags" on
+        field name="account_ids" which prevented from selecting several
+        accounts at the same time (quite useful when you want to select
+        an interval of accounts for example)
+        """
+        if 'account_ids' in vals and isinstance(vals['account_ids'], list):
+            account_ids = []
+            for account in vals['account_ids']:
+                if account[0] in (1, 4):
+                    account_ids.append(account[1])
+                elif account[0] == 6 and isinstance(account[2], list):
+                    account_ids += account[2]
+            vals['account_ids'] = [(6, 0, account_ids)]
+        res = super(AgedPartnerBalance, self).create(vals)
+        return res
+
     @api.multi
     def button_export_html(self):
         self.ensure_one()
diff --git a/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml b/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml
index 03be0cfb..b2584dcd 100644
--- a/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/aged_partner_balance_wizard_view.xml
@@ -27,7 +27,7 @@
                     <field name="receivable_accounts_only"/>
                     <field name="payable_accounts_only"/>
                 </group>
-                <field name="account_ids" widget="many2many_tags" nolabel="1" options="{'no_create': True}"/>
+                <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 <footer>
                     <button name="button_export_html" string="View"
                             type="object" default_focus="1" class="oe_highlight"/>
diff --git a/account_financial_report_qweb/wizard/general_ledger_wizard.py b/account_financial_report_qweb/wizard/general_ledger_wizard.py
index 5f9603fe..fc659204 100644
--- a/account_financial_report_qweb/wizard/general_ledger_wizard.py
+++ b/account_financial_report_qweb/wizard/general_ledger_wizard.py
@@ -110,6 +110,27 @@ class GeneralLedgerReportWizard(models.TransientModel):
         else:
             self.account_ids = None
 
+    @api.model
+    def create(self, vals):
+        """
+        This is a workaround for bug https://github.com/odoo/odoo/issues/14761
+        This bug impacts M2M fields in wizards filled-up via onchange
+        It replaces the workaround widget="many2many_tags" on
+        field name="account_ids" which prevented from selecting several
+        accounts at the same time (quite useful when you want to select
+        an interval of accounts for example)
+        """
+        if 'account_ids' in vals and isinstance(vals['account_ids'], list):
+            account_ids = []
+            for account in vals['account_ids']:
+                if account[0] in (1, 4):
+                    account_ids.append(account[1])
+                elif account[0] == 6 and isinstance(account[2], list):
+                    account_ids += account[2]
+            vals['account_ids'] = [(6, 0, account_ids)]
+        res = super(GeneralLedgerReportWizard, self).create(vals)
+        return res
+
     @api.onchange('partner_ids')
     def onchange_partner_ids(self):
         """Handle partners change."""
diff --git a/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml b/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml
index da6823a2..212ea804 100644
--- a/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/general_ledger_wizard_view.xml
@@ -39,7 +39,7 @@
                         <field name="receivable_accounts_only"/>
                         <field name="payable_accounts_only"/>
                     </group>
-                    <field name="account_ids" widget="many2many_tags" nolabel="1" options="{'no_create': True}"/>
+                    <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 </div>
                 <div attrs="{'invisible': [('not_only_one_unaffected_earnings_account', '=', False)]}">
                     <field name="not_only_one_unaffected_earnings_account" invisible="1"/>
diff --git a/account_financial_report_qweb/wizard/open_items_wizard.py b/account_financial_report_qweb/wizard/open_items_wizard.py
index e08ad693..84b35029 100644
--- a/account_financial_report_qweb/wizard/open_items_wizard.py
+++ b/account_financial_report_qweb/wizard/open_items_wizard.py
@@ -67,6 +67,27 @@ class OpenItemsReportWizard(models.TransientModel):
         else:
             self.account_ids = None
 
+    @api.model
+    def create(self, vals):
+        """
+        This is a workaround for bug https://github.com/odoo/odoo/issues/14761
+        This bug impacts M2M fields in wizards filled-up via onchange
+        It replaces the workaround widget="many2many_tags" on
+        field name="account_ids" which prevented from selecting several
+        accounts at the same time (quite useful when you want to select
+        an interval of accounts for example)
+        """
+        if 'account_ids' in vals and isinstance(vals['account_ids'], list):
+            account_ids = []
+            for account in vals['account_ids']:
+                if account[0] in (1, 4):
+                    account_ids.append(account[1])
+                elif account[0] == 6 and isinstance(account[2], list):
+                    account_ids += account[2]
+            vals['account_ids'] = [(6, 0, account_ids)]
+        res = super(OpenItemsReportWizard, self).create(vals)
+        return res
+
     @api.multi
     def button_export_html(self):
         self.ensure_one()
diff --git a/account_financial_report_qweb/wizard/open_items_wizard_view.xml b/account_financial_report_qweb/wizard/open_items_wizard_view.xml
index 46be957c..7f7184e3 100644
--- a/account_financial_report_qweb/wizard/open_items_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/open_items_wizard_view.xml
@@ -28,7 +28,7 @@
                     <field name="receivable_accounts_only"/>
                     <field name="payable_accounts_only"/>
                 </group>
-                <field name="account_ids" widget="many2many_tags" nolabel="1" options="{'no_create': True}"/>
+                <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 <footer>
                     <button name="button_export_html" string="View"
                             type="object" default_focus="1" class="oe_highlight"/>
diff --git a/account_financial_report_qweb/wizard/trial_balance_wizard.py b/account_financial_report_qweb/wizard/trial_balance_wizard.py
index 0025cb6e..1163c513 100644
--- a/account_financial_report_qweb/wizard/trial_balance_wizard.py
+++ b/account_financial_report_qweb/wizard/trial_balance_wizard.py
@@ -105,6 +105,27 @@ class TrialBalanceReportWizard(models.TransientModel):
         else:
             self.account_ids = None
 
+    @api.model
+    def create(self, vals):
+        """
+        This is a workaround for bug https://github.com/odoo/odoo/issues/14761
+        This bug impacts M2M fields in wizards filled-up via onchange
+        It replaces the workaround widget="many2many_tags" on
+        field name="account_ids" which prevented from selecting several
+        accounts at the same time (quite useful when you want to select
+        an interval of accounts for example)
+        """
+        if 'account_ids' in vals and isinstance(vals['account_ids'], list):
+            account_ids = []
+            for account in vals['account_ids']:
+                if account[0] in (1, 4):
+                    account_ids.append(account[1])
+                elif account[0] == 6 and isinstance(account[2], list):
+                    account_ids += account[2]
+            vals['account_ids'] = [(6, 0, account_ids)]
+        res = super(TrialBalanceReportWizard, self).create(vals)
+        return res
+
     @api.onchange('show_partner_details')
     def onchange_show_partner_details(self):
         """Handle partners change."""
diff --git a/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml b/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml
index 3486cfe3..18563896 100644
--- a/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml
+++ b/account_financial_report_qweb/wizard/trial_balance_wizard_view.xml
@@ -35,7 +35,7 @@
                         <field name="receivable_accounts_only"/>
                         <field name="payable_accounts_only"/>
                     </group>
-                    <field name="account_ids" widget="many2many_tags" nolabel="1" options="{'no_create': True}"/>
+                    <field name="account_ids" nolabel="1" options="{'no_create': True}"/>
                 </div>
                 <div attrs="{'invisible': [('not_only_one_unaffected_earnings_account', '=', False)]}">
                     <field name="not_only_one_unaffected_earnings_account" invisible="1"/>