Ronald Portier
7 years ago
10 changed files with 102 additions and 242 deletions
-
42account_bank_statement_import/parserlib.py
-
22account_bank_statement_import_mt940_nl_ing/mt940.py
-
42base_bank_account_number_unique/README.rst
-
21base_bank_account_number_unique/__init__.py
-
23base_bank_account_number_unique/__openerp__.py
-
55base_bank_account_number_unique/hooks.py
-
20base_bank_account_number_unique/models/__init__.py
-
55base_bank_account_number_unique/models/res_partner_bank.py
-
20base_bank_account_number_unique/tests/__init__.py
-
44base_bank_account_number_unique/tests/test_base_bank_account_number_unique.py
@ -1,21 +1,4 @@ |
|||
# -*- coding: utf-8 -*- |
|||
############################################################################## |
|||
# |
|||
# This module copyright (C) 2015 Therp BV <http://therp.nl>. |
|||
# |
|||
# This program is free software: you can redistribute it and/or modify |
|||
# it under the terms of the GNU Affero General Public License as |
|||
# published by the Free Software Foundation, either version 3 of the |
|||
# License, or (at your option) any later version. |
|||
# |
|||
# This program is distributed in the hope that it will be useful, |
|||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU Affero General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU Affero General Public License |
|||
# along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
# |
|||
############################################################################## |
|||
# © 2015-2017 Therp BV <https://therp.nl> |
|||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
|||
from . import models |
|||
from .hooks import post_init_hook |
|||
@ -1,55 +0,0 @@ |
|||
# -*- coding: utf-8 -*- |
|||
############################################################################## |
|||
# |
|||
# This module copyright (C) 2015 Therp BV <http://therp.nl>. |
|||
# |
|||
# This program is free software: you can redistribute it and/or modify |
|||
# it under the terms of the GNU Affero General Public License as |
|||
# published by the Free Software Foundation, either version 3 of the |
|||
# License, or (at your option) any later version. |
|||
# |
|||
# This program is distributed in the hope that it will be useful, |
|||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU Affero General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU Affero General Public License |
|||
# along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
# |
|||
############################################################################## |
|||
from openerp import _, SUPERUSER_ID |
|||
from openerp.exceptions import Warning as UserError |
|||
|
|||
|
|||
def post_init_hook(cr, pool): |
|||
"""check if your constraint was actually inserted, raise otherwise""" |
|||
if not pool['ir.model.constraint'].search(cr, SUPERUSER_ID, [ |
|||
('name', '=', 'res_partner_bank_unique_number'), |
|||
('model.model', '=', 'res.partner.bank'), |
|||
]): |
|||
max_account_numbers = 10 |
|||
cr.execute( |
|||
""" |
|||
with |
|||
res_partner_bank_sanitized as |
|||
(select id, acc_number, regexp_replace(acc_number, '\\W+', '', 'g') |
|||
acc_number_sanitized from res_partner_bank), |
|||
res_partner_bank_sanitized_grouped as |
|||
(select array_agg(id) ids, acc_number_sanitized, count(*) amount |
|||
from res_partner_bank_sanitized group by acc_number_sanitized) |
|||
select acc_number_sanitized from res_partner_bank_sanitized_grouped |
|||
where amount > 1 limit %s; |
|||
""", |
|||
(max_account_numbers,)) |
|||
duplicates = [acc_number for acc_number, in cr.fetchall()] |
|||
message = _( |
|||
"Module installation can't proceed as you have duplicate " |
|||
"account numbers in your system already. Please clean that up " |
|||
"and try again.\n" |
|||
"The following shows the first %d duplicate account numbers\n" |
|||
"%s\n" |
|||
"(if you see less than %d, those are the only duplicates)") % ( |
|||
max_account_numbers, '\n'.join(duplicates), |
|||
max_account_numbers, |
|||
) |
|||
raise UserError(message) |
|||
@ -1,20 +1,4 @@ |
|||
# -*- coding: utf-8 -*- |
|||
############################################################################## |
|||
# |
|||
# This module copyright (C) 2015 Therp BV <http://therp.nl>. |
|||
# |
|||
# This program is free software: you can redistribute it and/or modify |
|||
# it under the terms of the GNU Affero General Public License as |
|||
# published by the Free Software Foundation, either version 3 of the |
|||
# License, or (at your option) any later version. |
|||
# |
|||
# This program is distributed in the hope that it will be useful, |
|||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU Affero General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU Affero General Public License |
|||
# along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
# |
|||
############################################################################## |
|||
# © 2015-2017 Therp BV <https://therp.nl> |
|||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
|||
from . import res_partner_bank |
|||
@ -1,39 +1,40 @@ |
|||
# -*- coding: utf-8 -*- |
|||
############################################################################## |
|||
# |
|||
# This module copyright (C) 2015 Therp BV (<http://therp.nl>). |
|||
# |
|||
# This program is free software: you can redistribute it and/or modify |
|||
# it under the terms of the GNU Affero General Public License as |
|||
# published by the Free Software Foundation, either version 3 of the |
|||
# License, or (at your option) any later version. |
|||
# |
|||
# This program is distributed in the hope that it will be useful, |
|||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU Affero General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU Affero General Public License |
|||
# along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
# |
|||
############################################################################## |
|||
from openerp import models |
|||
# © 2015-2017 Therp BV <https://therp.nl> |
|||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
|||
from openerp import api, models, _ |
|||
from openerp.exceptions import ValidationError |
|||
|
|||
|
|||
class ResPartnerBank(models.Model): |
|||
_inherit = 'res.partner.bank' |
|||
|
|||
def copy_data(self, cr, uid, id, default=None, context=None): |
|||
if default is None: |
|||
default = {} |
|||
if context is None: |
|||
context = {} |
|||
default = default or {} |
|||
context = context or {} |
|||
if 'acc_number' not in default and 'default_acc_number' not in context: |
|||
default['acc_number'] = '' |
|||
return super(ResPartnerBank, self).copy_data( |
|||
cr, uid, id, default=default, context=context) |
|||
|
|||
_sql_constraints = [ |
|||
('unique_number', 'unique(sanitized_acc_number)', |
|||
'Account Number must be unique'), |
|||
] |
|||
@api.constrains('company_id', 'sanitized_acc_number') |
|||
def _check_unique_account(self): |
|||
for this in self: |
|||
check_domain = [ |
|||
('sanitized_acc_number', '=', this.sanitized_acc_number), |
|||
] |
|||
# No problem if one record has a company and the other not: |
|||
if this.company_id: |
|||
check_domain.append(('company_id', '=', this.company_id.id)) |
|||
else: |
|||
check_domain.append(('company_id', '=', False)) |
|||
# Do not find same record, if existing: |
|||
if this.exists(): |
|||
check_domain.append(('id', '<>', this.id)) |
|||
already_existing = self.search(check_domain) |
|||
if already_existing: |
|||
raise ValidationError( |
|||
_("Bank account %s already registered for %s.") % |
|||
(this.acc_number, |
|||
already_existing.partner_id.display_name or |
|||
_("unknown partner")) |
|||
) |
|||
@ -1,20 +1,4 @@ |
|||
# -*- coding: utf-8 -*- |
|||
############################################################################## |
|||
# |
|||
# This module copyright (C) 2015 Therp BV <http://therp.nl>. |
|||
# |
|||
# This program is free software: you can redistribute it and/or modify |
|||
# it under the terms of the GNU Affero General Public License as |
|||
# published by the Free Software Foundation, either version 3 of the |
|||
# License, or (at your option) any later version. |
|||
# |
|||
# This program is distributed in the hope that it will be useful, |
|||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU Affero General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU Affero General Public License |
|||
# along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
# |
|||
############################################################################## |
|||
# © 2015-2017 Therp BV <https://therp.nl> |
|||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
|||
from . import test_base_bank_account_number_unique |
|||
@ -1,42 +1,26 @@ |
|||
# -*- coding: utf-8 -*- |
|||
############################################################################## |
|||
# |
|||
# This module copyright (C) 2015 Therp BV <http://therp.nl>. |
|||
# |
|||
# This program is free software: you can redistribute it and/or modify |
|||
# it under the terms of the GNU Affero General Public License as |
|||
# published by the Free Software Foundation, either version 3 of the |
|||
# License, or (at your option) any later version. |
|||
# |
|||
# This program is distributed in the hope that it will be useful, |
|||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU Affero General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU Affero General Public License |
|||
# along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
# |
|||
############################################################################## |
|||
# © 2015-2017 Therp BV <https://therp.nl> |
|||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
|||
from openerp.tests.common import TransactionCase |
|||
from openerp.exceptions import Warning as UserError |
|||
from ..hooks import post_init_hook |
|||
from openerp.exceptions import ValidationError |
|||
|
|||
|
|||
class TestBaseBankAccountNumberUnique(TransactionCase): |
|||
|
|||
def test_base_bank_account_number_unique(self): |
|||
# drop our constraint, insert nonunique account numbers and see if |
|||
# the init hook catches this |
|||
self.env['ir.model.constraint'].search([ |
|||
('name', '=', 'res_partner_bank_unique_number'), |
|||
('model.model', '=', 'res.partner.bank'), |
|||
])._module_data_uninstall() |
|||
self.env['res.partner.bank'].create({ |
|||
"""Add a bank account, then try to add another one with the |
|||
same number.""" |
|||
bank_account_model = self.env['res.partner.bank'] |
|||
bank_account_model.create({ |
|||
'acc_number': 'BE1234567890', |
|||
'state': 'bank', |
|||
}) |
|||
self.env['res.partner.bank'].create({ |
|||
bank_account_model.create({ |
|||
'acc_number': 'BE 1234 567 890', |
|||
'state': 'bank', |
|||
}) |
|||
with self.assertRaises(UserError): |
|||
post_init_hook(self.cr, self.registry) |
|||
with self.assertRaises(ValidationError): |
|||
bank_account_model.create({ |
|||
'acc_number': 'BE 1234 567 890', |
|||
'state': 'bank', |
|||
}) |
|||
Write
Preview
Loading…
Cancel
Save
Reference in new issue