From c1f7c26f6eb4e0bf682080185f8e48658e6d2239 Mon Sep 17 00:00:00 2001
From: oleksandrpaziuk <31699656+oleksandrpaziuk@users.noreply.github.com>
Date: Thu, 12 Jul 2018 17:05:52 +0300
Subject: [PATCH] [11.0][FIX] Fix CAMT import without NTRY (#163)

---
 .../__manifest__.py                           |  2 +-
 .../models/parser.py                          | 10 ++--
 .../test_files/golden-camt053-no-ntry.pydata  |  1 +
 .../test_files/test-camt053-no-ntry           | 52 +++++++++++++++++++
 .../tests/test_import_bank_statement.py       |  5 ++
 5 files changed, 65 insertions(+), 5 deletions(-)
 create mode 100644 account_bank_statement_import_camt_oca/test_files/golden-camt053-no-ntry.pydata
 create mode 100644 account_bank_statement_import_camt_oca/test_files/test-camt053-no-ntry

diff --git a/account_bank_statement_import_camt_oca/__manifest__.py b/account_bank_statement_import_camt_oca/__manifest__.py
index f2ca11a..64b4978 100644
--- a/account_bank_statement_import_camt_oca/__manifest__.py
+++ b/account_bank_statement_import_camt_oca/__manifest__.py
@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     'name': 'CAMT Format Bank Statements Import',
-    'version': '11.0.1.0.0',
+    'version': '11.0.1.0.1',
     'license': 'AGPL-3',
     'author': 'Odoo Community Association (OCA), Therp BV',
     'website': 'https://github.com/OCA/bank-statement-import',
diff --git a/account_bank_statement_import_camt_oca/models/parser.py b/account_bank_statement_import_camt_oca/models/parser.py
index 0668422..1176c79 100644
--- a/account_bank_statement_import_camt_oca/models/parser.py
+++ b/account_bank_statement_import_camt_oca/models/parser.py
@@ -181,10 +181,12 @@ class CamtParser(models.AbstractModel):
         for entry_node in entry_nodes:
             transactions.extend(self.parse_entry(ns, entry_node))
         result['transactions'] = transactions
-        result['date'] = sorted(transactions,
-                                key=lambda x: x['date'],
-                                reverse=True
-                                )[0]['date']
+        result['date'] = None
+        if transactions:
+            result['date'] = sorted(transactions,
+                                    key=lambda x: x['date'],
+                                    reverse=True
+                                    )[0]['date']
         return result
 
     def check_version(self, ns, root):
diff --git a/account_bank_statement_import_camt_oca/test_files/golden-camt053-no-ntry.pydata b/account_bank_statement_import_camt_oca/test_files/golden-camt053-no-ntry.pydata
new file mode 100644
index 0000000..ca89faa
--- /dev/null
+++ b/account_bank_statement_import_camt_oca/test_files/golden-camt053-no-ntry.pydata
@@ -0,0 +1 @@
+(None, None, [])
diff --git a/account_bank_statement_import_camt_oca/test_files/test-camt053-no-ntry b/account_bank_statement_import_camt_oca/test_files/test-camt053-no-ntry
new file mode 100644
index 0000000..03f8f62
--- /dev/null
+++ b/account_bank_statement_import_camt_oca/test_files/test-camt053-no-ntry
@@ -0,0 +1,52 @@
+<Document xmlns="urn:iso:std:iso:20022:tech:xsd:camt.053.001.04">
+    <BkToCstmrStmt>
+        <GrpHdr>
+            <MsgId>TESTBANK/NL/1420561226673</MsgId>
+            <CreDtTm>2014-01-06T16:20:26.673Z</CreDtTm>
+        </GrpHdr>
+        <Stmt>
+            <Id>1234Test/1</Id>
+            <LglSeqNb>2</LglSeqNb>
+            <CreDtTm>2014-01-06T16:20:26.673Z</CreDtTm>
+            <FrToDt>
+                <FrDtTm>2014-01-05T00:00:00.000Z</FrDtTm>
+                <ToDtTm>2014-01-05T23:59:59.999Z</ToDtTm>
+            </FrToDt>
+            <Acct>
+                <Id>
+                    <IBAN>NL77ABNA0574908765</IBAN>
+                </Id>
+                <Nm>Example company</Nm>
+                <Svcr>
+                    <FinInstnId>
+                        <BIC>ABNANL2A</BIC>
+                    </FinInstnId>
+                </Svcr>
+            </Acct>
+            <Bal>
+                <Tp>
+                    <CdOrPrtry>
+                        <Cd>OPBD</Cd>
+                    </CdOrPrtry>
+                </Tp>
+                <Amt Ccy="CHF">1520.76</Amt>
+                <CdtDbtInd>CRDT</CdtDbtInd>
+                <Dt>
+                    <Dt>2014-01-05</Dt>
+                </Dt>
+            </Bal>
+            <Bal>
+                <Tp>
+                    <CdOrPrtry>
+                        <Cd>CLBD</Cd>
+                    </CdOrPrtry>
+                </Tp>
+                <Amt Ccy="CHF">1520.76</Amt>
+                <CdtDbtInd>CRDT</CdtDbtInd>
+                <Dt>
+                    <Dt>2014-01-05</Dt>
+                </Dt>
+            </Bal>
+        </Stmt>
+    </BkToCstmrStmt>
+</Document>
diff --git a/account_bank_statement_import_camt_oca/tests/test_import_bank_statement.py b/account_bank_statement_import_camt_oca/tests/test_import_bank_statement.py
index d96b051..5235f35 100644
--- a/account_bank_statement_import_camt_oca/tests/test_import_bank_statement.py
+++ b/account_bank_statement_import_camt_oca/tests/test_import_bank_statement.py
@@ -57,6 +57,11 @@ class TestParser(TransactionCase):
             'test-camt053-txdtls',
             'golden-camt053-txdtls.pydata')
 
+    def test_parse_no_ntry(self):
+        self._do_parse_test(
+            'test-camt053-no-ntry',
+            'golden-camt053-no-ntry.pydata')
+
 
 class TestImport(TransactionCase):
     """Run test to import camt import."""