Browse Source

Fix Nonetype error

The countrycode may be None so we shouldn't call .upper() on it.

Fixes #73
pull/83/head
Guewen Baconnier 9 years ago
committed by Sebastien LANGE
parent
commit
b0d50d6836
  1. 4
      base_phone/base_phone.py

4
base_phone/base_phone.py

@ -82,6 +82,8 @@ class PhoneCommon(models.AbstractModel):
"to allow the reformat of phone numbers", "to allow the reformat of phone numbers",
user.company_id.name) user.company_id.name)
countrycode = None countrycode = None
if countrycode:
countrycode = countrycode.upper()
# with country code = None, phonenumbers.parse() will work # with country code = None, phonenumbers.parse() will work
# with phonenumbers formatted in E164, but will fail with # with phonenumbers formatted in E164, but will fail with
# phone numbers in national format # phone numbers in national format
@ -90,7 +92,7 @@ class PhoneCommon(models.AbstractModel):
init_value = vals.get(field) init_value = vals.get(field)
try: try:
res_parse = phonenumbers.parse( res_parse = phonenumbers.parse(
vals.get(field), countrycode.upper())
vals.get(field), countrycode)
vals[field] = phonenumbers.format_number( vals[field] = phonenumbers.format_number(
res_parse, phonenumbers.PhoneNumberFormat.E164) res_parse, phonenumbers.PhoneNumberFormat.E164)
if init_value != vals[field]: if init_value != vals[field]:

Loading…
Cancel
Save