From 6b5ca7f585ca1275ade778886a5104c665109bd4 Mon Sep 17 00:00:00 2001
From: sbejaoui <souheil.bejaoui@acsone.eu>
Date: Thu, 29 Nov 2018 12:38:04 +0100
Subject: [PATCH] [IMP] - hide recurring_invoicing_type if recurring_rule_type
 is monthlylastday

for the monthlylastday case, pre-paid is logicly impossible,
if monthlylastday is set, we consider only post-paid case

[IMP] - Improve unit tests
---
 contract/tests/test_contract.py           | 1 +
 contract/views/abstract_contract_line.xml | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/contract/tests/test_contract.py b/contract/tests/test_contract.py
index 2dea7bc2..23b444e9 100644
--- a/contract/tests/test_contract.py
+++ b/contract/tests/test_contract.py
@@ -102,6 +102,7 @@ class TestContractBase(common.SavepointCase):
         cls.acct_line = cls.env['account.analytic.invoice.line'].create(
             cls.line_vals
         )
+        cls.acct_line.product_id.is_auto_renew = True
 
 
 class TestContract(TestContractBase):
diff --git a/contract/views/abstract_contract_line.xml b/contract/views/abstract_contract_line.xml
index 0823b29c..5e822fb1 100644
--- a/contract/views/abstract_contract_line.xml
+++ b/contract/views/abstract_contract_line.xml
@@ -49,9 +49,6 @@
                         </group>
                     </group>
                     <group name="recurrence_info">
-                        <group>
-                            <field name="recurring_invoicing_type"/>
-                        </group>
                         <group>
                             <label for="recurring_interval"/>
                             <div>
@@ -61,7 +58,10 @@
                                        class="oe_inline" nolabel="1"/>
                             </div>
                         </group>
-
+                        <group>
+                            <field name="recurring_invoicing_type"
+                            attrs="{'invisible': [('recurring_rule_type', '=', 'monthlylastday')]}"/>
+                        </group>
                     </group>
                 </sheet>
             </form>