From deeede7244b6825e237cd857580e11d4938ca8bb Mon Sep 17 00:00:00 2001 From: Matjaz Mozetic Date: Fri, 2 Aug 2019 20:28:34 +0200 Subject: [PATCH] [FIX] Optimize code for codecov --- contract/models/account_analytic_invoice_line.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/contract/models/account_analytic_invoice_line.py b/contract/models/account_analytic_invoice_line.py index b7f1127b..b8160a75 100644 --- a/contract/models/account_analytic_invoice_line.py +++ b/contract/models/account_analytic_invoice_line.py @@ -17,18 +17,16 @@ class AccountAnalyticInvoiceLine(models.Model): qty = 0.0 for inv_line in line.invoice_lines: if inv_line.invoice_id.state not in ['cancel']: - if inv_line.invoice_id.type == 'in_invoice': + if inv_line.invoice_id.type in [ + 'in_invoice', 'out_refund' + ]: qty += inv_line.uom_id._compute_quantity( inv_line.quantity, line.uom_id) - elif inv_line.invoice_id.type == 'in_refund': + elif inv_line.invoice_id.type in [ + 'out_invoice', 'in_refund' + ]: qty -= inv_line.uom_id._compute_quantity( inv_line.quantity, line.uom_id) - elif inv_line.invoice_id.type == 'out_invoice': - qty -= inv_line.uom_id._compute_quantity( - inv_line.quantity, line.uom_id) - elif inv_line.invoice_id.type == 'out_refund': - qty += inv_line.uom_id._compute_quantity( - inv_line.quantity, line.uom_id) line.qty_invoiced = qty analytic_account_id = fields.Many2one(