From e755f2fee0f95cea217c8c6dcc0ce4fe140116b3 Mon Sep 17 00:00:00 2001
From: sbejaoui <souheil.bejaoui@acsone.eu>
Date: Thu, 24 Jan 2019 12:08:00 +0100
Subject: [PATCH] [IMP] - improve sale order line view

---
 .../views/sale_order.xml                      | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/product_contract_variable_quantity/views/sale_order.xml b/product_contract_variable_quantity/views/sale_order.xml
index c441c273..802d8059 100644
--- a/product_contract_variable_quantity/views/sale_order.xml
+++ b/product_contract_variable_quantity/views/sale_order.xml
@@ -14,13 +14,15 @@
         <field name="model">sale.order</field>
         <field name="inherit_id" ref="sale.view_order_form"/>
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='order_line']/form//field[@name='product_uom_qty']"
-                   position="after">
-                <field name="qty_type"
-                attrs="{'required': [('is_contract', '=', True)], 'invisible': [('is_contract', '=', False)]}"/>
-                <field name="qty_formula_id"
-                       attrs="{'required': [('qty_type', '=', 'variable')], 'invisible': [('qty_type', '!=', 'variable')]}"
-                />
+            <xpath expr="//field[@name='order_line']/form//label[@for='name']"
+                   position="before">
+                <group col="4">
+                    <field name="qty_type"
+                           attrs="{'required': [('is_contract', '=', True)], 'invisible': [('is_contract', '=', False)]}"/>
+                    <field name="qty_formula_id"
+                           attrs="{'required': [('qty_type', '=', 'variable')], 'invisible': [('qty_type', '!=', 'variable')]}"
+                    />
+                </group>
             </xpath>
             <xpath expr="//field[@name='order_line']/tree//field[@name='product_uom_qty']"
                    position="after">
@@ -29,9 +31,6 @@
                 <field name="qty_formula_id"
                        attrs="{'column_invisible': [('parent.is_contract', '=', False)]}"/>
             </xpath>
-            <xpath expr="//field[@name='order_line']/form//field[@name='product_uom_qty']" position="attributes">
-                <attribute name="attrs">{'required': [('qty_type', '=', 'fixed')], 'invisible': [('qty_type', '!=', 'fixed')]}</attribute>
-            </xpath>
         </field>
     </record>