contract

History

Jairo Llopis 173b2b2db2 [10.0][IMP] contract: Performance boost 🚀 With this patch we save about 83% of the execution time when generating invoices in batch. # Optimizations made ## Recompute once at the end of the batch This part avoids recomputing many fields per record. Instead, global recomputations are triggered at the end of the block: ```python with _self.env.norecompute(): ... invoices.compute_taxes() _self.recompute() ``` Notice the explicit call to `compute_taxes()`, which was explicit before also, but it was done once per invoice, losing batch-computing boost. ## Disabling prefetch for extra fields It's done in this part: ```python _self = self.with_context(prefetch_fields=False) ``` Prefetching makes sense when we are going to use a lot of fields for a model that has only a few. In our case, we are using not much fields, but the models involved have lots of them. This produces more queries to get those fields, but the queries are noticeably smaller. At the end of the day, it saves a lot of time, which is what matters. ## Disabling track mail creation This part does it: ```diff ctx.update({ + 'mail_notrack': True, 'next_date': next_date, ``` It makes that when creating invoices, we don't create the "Invoice created" message. ## Precomputing price Obtaining `price_unit` from `contract.recurring_invoice_line_ids` was quite expenisve in terms of CPU, and it was being made once per line, each one in a different context, which means also a different cache. Instead of that, lines now share a single context, and are computed before starting the batch. This code precomputes stuff: ```python # Precompute expensive computed fields in batch recurring_lines = _self.mapped("recurring_invoice_line_ids") recurring_lines._fields["price_unit"].determine_value(recurring_lines) ``` And the usage of 2 different environments done inside `_create_invoice()` (`self` and `_self`) guarantee that the invoices are filled with the correct data, but also that the lines use the cached precomputed value instead of having to compute it each time. # Performance gain According to my tests, generating 10 invoices took 62 seconds before, and it takes about 18 seconds now.		6 years ago
..
i18n	[UPD] Update contract_payment_mode.pot	6 years ago
models	[IMP] contract_payment_mode: Onchange payment mode vals	7 years ago
tests	[FIX] contract_payment_auto: Fix freze wkhtmltopdf freezed	7 years ago
views	contract_payment_mode: Migration to 9.0	8 years ago
README.rst	[IMP] contract_payment_mode: Onchange payment mode vals	7 years ago
__init__.py	[MIG] contract_payment_mode: Migration to 10.0	8 years ago
__manifest__.py	[IMP] contract_payment_mode: Onchange payment mode vals	7 years ago
hooks.py	[MIG] contract_payment_mode: Migration to 10.0	8 years ago

README.rst

.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
   :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
   :alt: License: AGPL-3

=====================
Contract Payment Mode
=====================

This module allows to set a payment mode on contract for creating the invoices
with this payment mode.

Configuration
=============

Your user should be a Sales Manager or Accountant.

Usage
=====

#. Go to *Accounting > Sales > Contracts*.
#. Create one.
#. Select a partner to which invoice.
#. If the partner has a payment mode, this payment mode is selected here.
#. If not, or if you want another payment mode, you can change it in the
   corresponding field.
#. Click on **Generate recurring invoices automatically** checkbox.
#. Add a product to invoice.
#. If you create an invoice, new invoice will have the selected payment mode.


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
   :alt: Try me on Runbot
   :target: https://runbot.odoo-community.org/runbot/110/10.0

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/contract/issues>`_.
In case of trouble, please
check there if your issue has already been reported. If you spotted it first,
help us smash it by providing detailed and welcomed feedback.

Credits
=======

Contributors
------------

* Ángel Moya <angel.moya@domatix.com>
* Antonio Espinosa <antonioea@antiun.com>
* Vicent Cubells <vicent.cubells@tecnativa.com>
* David Vidal <david.vidal@tecnativa.com>
* Carlos Dauden <carlos.dauden@tecnativa.com>


Maintainer
----------

.. image:: https://odoo-community.org/logo.png
   :alt: Odoo Community Association
   :target: https://odoo-community.org

This module is maintained by the OCA.

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit https://odoo-community.org.