[FIX] privacy_consent: Avoid race condition with mail queue cron
Before this patch, all privacy consent emails were forced to be sent under a context with `mark_consent_sent=True` to track the state change and trigger the attached server action.
When using the automatic mode, if a separate cron job started running the mail queue, it could happen that mails were being sent from that another worker, losing the context key and, as such, being sent without token and without being marked as sent nor executing the attached server action (if any).
To avoid this problem, now the context dependency is removed. After all, the `mail.mail` object is only created when sending in `mass_mail` model, so other kind of notifications or messages are not affected. When a mail of type `mass_mail` is sent, we can assume that it is asking for consent and we can move draft consent requests to sent.
6 years ago [FIX] privacy_consent: Avoid race condition with mail queue cron
Before this patch, all privacy consent emails were forced to be sent under a context with `mark_consent_sent=True` to track the state change and trigger the attached server action.
When using the automatic mode, if a separate cron job started running the mail queue, it could happen that mails were being sent from that another worker, losing the context key and, as such, being sent without token and without being marked as sent nor executing the attached server action (if any).
To avoid this problem, now the context dependency is removed. After all, the `mail.mail` object is only created when sending in `mass_mail` model, so other kind of notifications or messages are not affected. When a mail of type `mass_mail` is sent, we can assume that it is asking for consent and we can move draft consent requests to sent.
6 years ago |
|
# -*- coding: utf-8 -*- # Copyright 2018 Tecnativa - Jairo Llopis # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
from odoo import _, api, fields, models from odoo.exceptions import ValidationError from odoo.tools.safe_eval import safe_eval
class PrivacyActivity(models.Model): _inherit = 'privacy.activity'
server_action_id = fields.Many2one( "ir.actions.server", "Server action", domain=[ ("model_id.model", "=", "privacy.consent"), ], help="Run this action when a new consent request is created or its " "acceptance status is updated.", ) consent_ids = fields.One2many( "privacy.consent", "activity_id", "Consents", ) consent_count = fields.Integer( "Consents", compute="_compute_consent_count", ) consent_required = fields.Selection( [("auto", "Automatically"), ("manual", "Manually")], "Ask subjects for consent", help="Enable if you need to track any kind of consent " "from the affected subjects", ) consent_template_id = fields.Many2one( "mail.template", "Email template", default=lambda self: self._default_consent_template_id(), domain=[ ("model", "=", "privacy.consent"), ], help="Email to be sent to subjects to ask for consent. " "A good template should include details about the current " "consent request status, how to change it, and where to " "get more information.", ) default_consent = fields.Boolean( "Accepted by default", help="Should we assume the subject has accepted if we receive no " "response?", )
# Hidden helpers help user design new templates consent_template_default_body_html = fields.Text( compute="_compute_consent_template_defaults", ) consent_template_default_subject = fields.Char( compute="_compute_consent_template_defaults", )
@api.model def _default_consent_template_id(self): return self.env.ref("privacy_consent.template_consent", False)
@api.depends("consent_ids") def _compute_consent_count(self): groups = self.env["privacy.consent"].read_group( [("activity_id", "in", self.ids)], ["activity_id"], ["activity_id"], ) for group in groups: self.browse(group["activity_id"][0], self._prefetch) \ .consent_count = group["activity_id_count"]
def _compute_consent_template_defaults(self): """Used in context values, to help users design new templates.""" template = self._default_consent_template_id() if template: self.update({ "consent_template_default_body_html": template.body_html, "consent_template_default_subject": template.subject, })
@api.constrains("consent_required", "consent_template_id") def _check_auto_consent_has_template(self): """Require a mail template to automate consent requests.""" for one in self: if one.consent_required == "auto" and not one.consent_template_id: raise ValidationError(_( "Specify a mail template to ask automated consent." ))
@api.constrains("consent_required", "subject_find") def _check_consent_required_subject_find(self): for one in self: if one.consent_required and not one.subject_find: raise ValidationError(_( "Require consent is available only for subjects " "in current database." ))
@api.model def _cron_new_consents(self): """Ask all missing automatic consent requests.""" automatic = self.search([("consent_required", "=", "auto")]) automatic.action_new_consents()
@api.onchange("consent_required") def _onchange_consent_required_subject_find(self): """Find subjects automatically if we require their consent.""" if self.consent_required: self.subject_find = True
def action_new_consents(self): """Generate new consent requests.""" consents = self.env["privacy.consent"] # Skip activitys where consent is not required for one in self.with_context(active_test=False) \ .filtered("consent_required"): domain = [ ("id", "not in", one.mapped("consent_ids.partner_id").ids), ("email", "!=", False), ] + safe_eval(one.subject_domain) # Create missing consent requests for missing in self.env["res.partner"].search(domain): consents |= consents.create({ "partner_id": missing.id, "accepted": one.default_consent, "activity_id": one.id, }) # Avoid race condition where a user could click on accept/reject link # in his email before its consent record is saved to the database consents.env.cr.commit() # Send consent request emails for automatic activitys consents.action_auto_ask() # Redirect user to new consent requests generated return { "domain": [("id", "in", consents.ids)], "name": _("Generated consents"), "res_model": consents._name, "type": "ir.actions.act_window", "view_mode": "tree,form", }
|