You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

76 lines
3.6 KiB

privacy_consent: Separate automated emails send process Before https://github.com/OCA/data-protection/pull/29 there was a race condition where an email could be sent while the same transaction that created the `privacy.consent` record still wasn't committed, producing a 404 error if the user clicked on "Accept" or "Reject" before all mails were sent. To avoid that, a raw `cr.commit()` was issued, but this produced another situation where the user had to wait until the full email queue is cleared to get his page loaded. It wasn't an error, but a long queue meant several minutes waiting, and it's ulikely that an average human is so patient. So, here's the final fix (I hope!). The main problem was that I was looking in the wrong place to send the email. It turns out that the `self.post_message_with_template()` method is absolutely helpless in the case at hand, where these criteria must be met: * E-mail must be enqueued, no matter if there are less or more than 50 consents to send. * The template must be processed per record. * In an ideal world, a `cr.commit()` must be issued after each sent mail. The metod that was being used: * Didn't allow to use `auto_commit` mode. * Only allowed to render the template per record if called with `composition_mode="mass_mail"`. * Only allowed to enqueue emails if called with `composition_mode="mass_post"`. Obviously, I cannot set 2 different values for `composition_mode`, so a different strategy had to be used. I discovered that the `mail.template` model has a helpful method called `send_mail()` that, by default: * Renders the template per record * Enqueues the email * The email queue is cleared in `auto_commit=True` mode. So, from now on, problems are gone: * The user click, or the cron run, will just generate the missing `privacy.consent` records and enqueue mails for them. * The mail queue manager will send them later, in `auto_commit` mode. * After sending the e-mail, this module will set the `privacy.consent` record as `sent`. * Thanks to *not* sending the email, the process the user faces when he hits the "generate" button is faster. * Instructions in the README and text in the "generate" button are updated to reflect this new behavior. * Thanks to the `auto_commit` feature, if Odoo is rebooted in the middle of a mail queue clearance, the records that were sent remain properly marked as sent, and the missing mails will be sent after the next boot. * No hardcoded commits. * No locked transactions. * BTW I discovered that 2 different emails were created when creating a new consent. I started using `mail_create_nolog=True` to avoid that problem and only log a single creation message. Note to self: never use again `post_message_with_template()`.
5 years ago
  1. <?xml version="1.0" encoding="utf-8" ?>
  2. <!-- Copyright 2018 Tecnativa - Jairo Llopis
  3. License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
  4. <data>
  5. <record id="activity_form" model="ir.ui.view">
  6. <field name="name">Add consent fields</field>
  7. <field name="model">privacy.activity</field>
  8. <field name="inherit_id" ref="privacy.activity_form" />
  9. <field name="arch" type="xml">
  10. <div name="button_box" position="inside">
  11. <button
  12. attrs='{"invisible": [("consent_required", "=", False)]}'
  13. class="oe_stat_button"
  14. context='{"search_default_activity_id": active_id}'
  15. icon="fa-handshake-o"
  16. name="%(consent_action)d"
  17. type="action"
  18. >
  19. <field name="consent_count" widget="statinfo" />
  20. </button>
  21. </div>
  22. <notebook name="advanced" position="inside">
  23. <page string="Consent" name="consent">
  24. <group>
  25. <label for="consent_required" />
  26. <div>
  27. <field name="consent_required" class="oe_inline" />
  28. <button
  29. attrs='{"invisible": [("consent_required", "!=", "manual")]}'
  30. class="btn-link"
  31. icon="fa-user-plus"
  32. name="action_new_consents"
  33. type="object"
  34. string="Generate missing draft consent requests"
  35. />
  36. <button
  37. attrs='{"invisible": [("consent_required", "!=", "auto")]}'
  38. class="btn-link"
  39. icon="fa-user-plus"
  40. name="action_new_consents"
  41. type="object"
  42. string="Generate and enqueue missing consent requests"
  43. confirm="This could enqueue many consent emails, are you sure to proceed?"
  44. />
  45. </div>
  46. </group>
  47. <group attrs='{"invisible": [("consent_required", "=", False)]}'>
  48. <group>
  49. <field name="default_consent" />
  50. <field name="server_action_id" groups="base.group_no_one" />
  51. </group>
  52. <group>
  53. <field
  54. name="consent_template_default_body_html"
  55. invisible="1"
  56. />
  57. <field
  58. name="consent_template_default_subject"
  59. invisible="1"
  60. />
  61. <field
  62. name="consent_template_id"
  63. attrs='{"required": [("consent_required", "=", "auto")]}'
  64. context='{
  65. "default_model": "privacy.consent",
  66. "default_body_html": consent_template_default_body_html,
  67. "default_subject": consent_template_default_subject,
  68. }'
  69. />
  70. </group>
  71. </group>
  72. </page>
  73. </notebook>
  74. </field>
  75. </record>
  76. </data>