From 1381d57f676261adc3ecdb2c4aa0b22486402fbc Mon Sep 17 00:00:00 2001
From: Patrick Wilson <36892066+patrickrwilson@users.noreply.github.com>
Date: Wed, 27 Apr 2022 16:21:53 -0400
Subject: [PATCH] [IMP] partner_tier_validation (Prevent bypass)

This prevents a scenario where a user can bypass validation by moving the partner to a 'cancel' stage and then moving it back to confirmed.
---
 partner_tier_validation/models/res_partner.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/partner_tier_validation/models/res_partner.py b/partner_tier_validation/models/res_partner.py
index 9c251a958..3b303bf4b 100644
--- a/partner_tier_validation/models/res_partner.py
+++ b/partner_tier_validation/models/res_partner.py
@@ -9,7 +9,7 @@ class ResPartner(models.Model):
     _inherit = ["res.partner", "tier.validation"]
 
     _tier_validation_buttons_xpath = "/form/header/field[@name='state']"
-    _state_from = ["draft"]
+    _state_from = ["draft", "cancel"]
     _state_to = ["confirmed"]
     _cancel_state = ["inactive"]
     _tier_validation_manual_config = False
@@ -45,6 +45,6 @@ class ResPartner(models.Model):
             stage = self.env["res.partner.stage"].browse(stage_id)
             vals["state"] = stage.state
         res = super().write(vals)
-        if "stage_id" in vals:
+        if "stage_id" in vals and vals.get("stage_id") in self._state_from:
             self.restart_validation()
         return res