From 70daebdcfa1dd55baa0c8962ebdf056776675d42 Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Fri, 26 Jun 2020 11:38:08 +0100 Subject: [PATCH] [MIG] partner_contact_lang: Migration to 12.0 Backport from v13 - Remove stuff related to `active_lang_count`, which doesn't exist in v12. - Properly pass parent lang to children. Workaround https://github.com/odoo/odoo/issues/53738. @Tecnativa TT24503 --- oca_dependencies.txt | 1 + partner_contact_lang/README.rst | 28 ++++++++--- partner_contact_lang/__manifest__.py | 4 +- partner_contact_lang/models/res_partner.py | 10 +++- partner_contact_lang/readme/CONTRIBUTORS.rst | 5 +- partner_contact_lang/readme/INSTALL.rst | 2 + partner_contact_lang/readme/ROADMAP.rst | 3 ++ .../static/description/index.html | 50 ++++++++++++------- .../views/res_partner_view.xml | 11 +++- 9 files changed, 83 insertions(+), 31 deletions(-) create mode 100644 oca_dependencies.txt create mode 100644 partner_contact_lang/readme/INSTALL.rst create mode 100644 partner_contact_lang/readme/ROADMAP.rst diff --git a/oca_dependencies.txt b/oca_dependencies.txt new file mode 100644 index 000000000..9c8c9172c --- /dev/null +++ b/oca_dependencies.txt @@ -0,0 +1 @@ +server-tools diff --git a/partner_contact_lang/README.rst b/partner_contact_lang/README.rst index 85b86e8a9..16e211b39 100644 --- a/partner_contact_lang/README.rst +++ b/partner_contact_lang/README.rst @@ -14,13 +14,13 @@ Manage language in contacts :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html :alt: License: AGPL-3 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github - :target: https://github.com/OCA/partner-contact/tree/13.0/partner_contact_lang + :target: https://github.com/OCA/partner-contact/tree/12.0/partner_contact_lang :alt: OCA/partner-contact .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png - :target: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_contact_lang + :target: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_lang :alt: Translate me on Weblate .. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png - :target: https://runbot.odoo-community.org/runbot/134/13.0 + :target: https://runbot.odoo-community.org/runbot/134/12.0 :alt: Try me on Runbot |badge1| |badge2| |badge3| |badge4| |badge5| @@ -44,19 +44,32 @@ set the new conctact with a different language if needed. .. contents:: :local: +Installation +============ + +This module depends on ``base_view_inheritance_extension``, available in +`OCA/server-tools `__. + Usage ===== #. Go to any company partner has contacts. #. Click on any contact and you will be able to edit the language. +Known issues / Roadmap +====================== + +* When https://github.com/odoo/odoo/issues/53738 is fixed, remove the + ``partner_lang`` field and the dependency on + ``base_view_inheritance_extension``. + Bug Tracker =========== Bugs are tracked on `GitHub Issues `_. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us smashing it by providing a detailed and welcomed -`feedback `_. +`feedback `_. Do not contact contributors directly about support or help with technical issues. @@ -71,13 +84,14 @@ Authors Contributors ~~~~~~~~~~~~ +* Javier Iniesta +* Pedro Evaristo Gonzalez Sanchez * `Tecnativa `__: - * Javier Iniesta * Vicent Cubells * David Vidal * Cristina Martín - * Pedro Evaristo Gonzalez Sanchez + * Jairo Llopis Maintainers ~~~~~~~~~~~ @@ -92,6 +106,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use. -This module is part of the `OCA/partner-contact `_ project on GitHub. +This module is part of the `OCA/partner-contact `_ project on GitHub. You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/partner_contact_lang/__manifest__.py b/partner_contact_lang/__manifest__.py index 1f5bd4658..020c3bc88 100644 --- a/partner_contact_lang/__manifest__.py +++ b/partner_contact_lang/__manifest__.py @@ -5,12 +5,12 @@ { "name": "Manage language in contacts", - "version": "13.0.1.0.0", + "version": "12.0.1.0.0", "category": "Sales", "license": "AGPL-3", "author": "Tecnativa," "Odoo Community Association (OCA)", "website": "https://github.com/OCA/partner-contact/", - "depends": ["base"], + "depends": ["base_view_inheritance_extension"], "data": ["views/res_partner_view.xml"], "installable": True, } diff --git a/partner_contact_lang/models/res_partner.py b/partner_contact_lang/models/res_partner.py index 0d82d9e75..acbab0db3 100644 --- a/partner_contact_lang/models/res_partner.py +++ b/partner_contact_lang/models/res_partner.py @@ -2,12 +2,20 @@ # Copyright 2017 Tecnativa - Vicent Cubells # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). -from odoo import api, models +from odoo import api, fields, models class ResPartner(models.Model): _inherit = "res.partner" + # HACK https://github.com/odoo/odoo/issues/53738 + # TODO Remove when fixed + partner_lang = fields.Selection( + string="Partner lang", + related="lang", + readonly=True, + ) + def write(self, vals): """Propagate a language change in the partner to the child contacts.""" res = super(ResPartner, self).write(vals) diff --git a/partner_contact_lang/readme/CONTRIBUTORS.rst b/partner_contact_lang/readme/CONTRIBUTORS.rst index f022bc6f4..11e75dd3b 100644 --- a/partner_contact_lang/readme/CONTRIBUTORS.rst +++ b/partner_contact_lang/readme/CONTRIBUTORS.rst @@ -1,7 +1,8 @@ +* Javier Iniesta +* Pedro Evaristo Gonzalez Sanchez * `Tecnativa `__: - * Javier Iniesta * Vicent Cubells * David Vidal * Cristina Martín - * Pedro Evaristo Gonzalez Sanchez + * Jairo Llopis diff --git a/partner_contact_lang/readme/INSTALL.rst b/partner_contact_lang/readme/INSTALL.rst new file mode 100644 index 000000000..9efc973b1 --- /dev/null +++ b/partner_contact_lang/readme/INSTALL.rst @@ -0,0 +1,2 @@ +This module depends on ``base_view_inheritance_extension``, available in +`OCA/server-tools `__. diff --git a/partner_contact_lang/readme/ROADMAP.rst b/partner_contact_lang/readme/ROADMAP.rst new file mode 100644 index 000000000..5f3dd8912 --- /dev/null +++ b/partner_contact_lang/readme/ROADMAP.rst @@ -0,0 +1,3 @@ +* When https://github.com/odoo/odoo/issues/53738 is fixed, remove the + ``partner_lang`` field and the dependency on + ``base_view_inheritance_extension``. diff --git a/partner_contact_lang/static/description/index.html b/partner_contact_lang/static/description/index.html index e68a68874..0697b2610 100644 --- a/partner_contact_lang/static/description/index.html +++ b/partner_contact_lang/static/description/index.html @@ -367,7 +367,7 @@ ul.auto-toc { !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! --> -

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runbot

+

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runbot

Odoo by default propagate language field to the created contacts from their form, but it doesn’t allow to change it once created.

This module fills this gap, and also provides other facilities for the @@ -382,60 +382,76 @@ set the new conctact with a different language if needed.

Table of contents

+
+

Installation

+

This module depends on base_view_inheritance_extension, available in +OCA/server-tools.

+
-

Usage

+

Usage

  1. Go to any company partner has contacts.
  2. Click on any contact and you will be able to edit the language.
+
+

Known issues / Roadmap

+ +
-

Bug Tracker

+

Bug Tracker

Bugs are tracked on GitHub Issues. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us smashing it by providing a detailed and welcomed -feedback.

+feedback.

Do not contact contributors directly about support or help with technical issues.

-

Credits

+

Credits

-

Authors

+

Authors

  • Tecnativa
-

Contributors

+

Contributors

-

Maintainers

+

Maintainers

This module is maintained by the OCA.

Odoo Community Association

OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use.

-

This module is part of the OCA/partner-contact project on GitHub.

+

This module is part of the OCA/partner-contact project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

diff --git a/partner_contact_lang/views/res_partner_view.xml b/partner_contact_lang/views/res_partner_view.xml index cecd9269e..71bac0c6a 100644 --- a/partner_contact_lang/views/res_partner_view.xml +++ b/partner_contact_lang/views/res_partner_view.xml @@ -12,13 +12,20 @@ expr="//field[@name='child_ids']/form/sheet/field[@name='lang']" position="replace" > - - + + + + + + + partner_lang +