From aa8d63fe32c803610c6e3a112fe4a5d6657c4b2a Mon Sep 17 00:00:00 2001 From: Antonio Espinosa Date: Thu, 21 Jul 2016 18:32:45 +0200 Subject: [PATCH] Add a comment to remember why we call write with sudo --- partner_firstname/models/res_partner.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/partner_firstname/models/res_partner.py b/partner_firstname/models/res_partner.py index f59a0abe9..5131b1398 100644 --- a/partner_firstname/models/res_partner.py +++ b/partner_firstname/models/res_partner.py @@ -236,5 +236,10 @@ class ResPartner(models.Model): name = vals.get('name') if name and all(name == partner.name for partner in self): vals.pop('name', None) + # If vals is empty (only write name field and with the same value) + # Avoid access checking here + # https://github.com/odoo/odoo/blob/ + # 8b83119fad7ccae9f091f12b6ac89c2c31e4bac3/openerp/addons/base/res/ + # res_partner.py#L569 this = self.sudo() if not vals else self return super(ResPartner, this).write(vals)