From ab4a91c0dac63bd090bf9cb1446f0e399ff84b0c Mon Sep 17 00:00:00 2001
From: "Pedro M. Baeza" <pedro.baeza@gmail.com>
Date: Wed, 17 Oct 2018 10:31:04 +0200
Subject: [PATCH] [IMP] partner_ref_unique: Extend tests use cases

---
 .../tests/test_res_partner_ref.py             | 30 +++++++++++++++----
 1 file changed, 25 insertions(+), 5 deletions(-)

diff --git a/partner_ref_unique/tests/test_res_partner_ref.py b/partner_ref_unique/tests/test_res_partner_ref.py
index f61ee8682..bd97bda3b 100644
--- a/partner_ref_unique/tests/test_res_partner_ref.py
+++ b/partner_ref_unique/tests/test_res_partner_ref.py
@@ -10,11 +10,11 @@ class TestResPartnerRefUnique(common.SavepointCase):
     def setUpClass(cls):
         super(TestResPartnerRefUnique, cls).setUpClass()
         cls.company = cls.env.ref('base.main_company')
-        partner_obj = cls.env['res.partner']
-        cls.partner1 = partner_obj.create({
+        cls.partner_obj = cls.env['res.partner']
+        cls.partner1 = cls.partner_obj.create({
             'name': 'Partner1',
         })
-        cls.partner2 = partner_obj.create({
+        cls.partner2 = cls.partner_obj.create({
             'name': 'Partner2',
         })
 
@@ -24,13 +24,21 @@ class TestResPartnerRefUnique(common.SavepointCase):
         self.partner1.ref = 'same_ref'
         self.partner2.ref = 'same_ref'
         self.assertEqual(self.partner1.ref, self.partner2.ref)
+        # Here there shouldn't be any problem
+        self.partner_obj.create({
+            'name': 'other',
+            'ref': 'same_ref',
+        })
         self.partner2.ref = False
-
         # Test can't create/modify partner with same ref
         self.company.partner_ref_unique = 'all'
         with self.assertRaises(ValidationError):
             self.partner2.ref = 'same_ref'
-
+        with self.assertRaises(ValidationError):
+            self.partner_obj.create({
+                'name': 'other',
+                'ref': 'same_ref',
+            })
         # Test can't create/modify companies with same ref
         self.company.partner_ref_unique = 'companies'
         self.partner2.ref = 'same_ref'
@@ -40,3 +48,15 @@ class TestResPartnerRefUnique(common.SavepointCase):
         self.partner2.is_company = True
         with self.assertRaises(ValidationError):
             self.partner2.ref = 'same_ref'
+        with self.assertRaises(ValidationError):
+            self.partner_obj.create({
+                'is_company': True,
+                'name': 'other',
+                'ref': 'same_ref',
+            })
+        # Here there shouldn't be any problem
+        self.partner_obj.create({
+            'is_company': False,
+            'name': 'other',
+            'ref': 'same_ref',
+        })