From af201a5517baad0ac6a560411c339e021d167d3c Mon Sep 17 00:00:00 2001 From: Mourad Date: Fri, 8 Jun 2018 14:08:59 +0200 Subject: [PATCH] [FIX] fix name constrains --- partner_firstname/exceptions.py | 4 +++- partner_firstname/models/res_partner.py | 7 +++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/partner_firstname/exceptions.py b/partner_firstname/exceptions.py index d2fdea566..21eb49df5 100644 --- a/partner_firstname/exceptions.py +++ b/partner_firstname/exceptions.py @@ -8,5 +8,7 @@ class EmptyNamesError(exceptions.ValidationError): def __init__(self, record, value=_("No name is set.")): self.record = record self._value = value - self.name = _("Error(s) with partner %d's name.") % record.id + self.name = _( + "Error(s): at least one name (name, firstname or " + "lastname) is mandatory for partner (id : %d).") % record.id self.args = (self.name, value) diff --git a/partner_firstname/models/res_partner.py b/partner_firstname/models/res_partner.py index 0c57a81b8..f5dd5b24c 100644 --- a/partner_firstname/models/res_partner.py +++ b/partner_firstname/models/res_partner.py @@ -203,10 +203,9 @@ class ResPartner(models.Model): def _check_name(self): """Ensure at least one name is set.""" for record in self: - if all(( - record.type == 'contact' or record.is_company, - not (record.firstname or record.lastname) - )): + if ( + not (record.firstname or record.lastname or record.name) + ): raise exceptions.EmptyNamesError(record) @api.onchange("firstname", "lastname")