[PORT] partner_firstname to 9.0

- add missing authors
- use reduced license header
- move models in models directory
- adapt views
- show firstname, lastname only in edit mode
- use company_type in views instead of is_company
- adapt constraint on contacts

partner_firstname/README.rst

@@ -39,11 +39,28 @@ Contributors
 ------------
 
 * Nicolas Bessi <nicolas.bessi@camptocamp.com>
+* Yannick Vaucher <yannick.vaucher@camptocamp.com>
+* Vincent Renaville <vincent.renaville@camptocamp.com>
+* Guewen Baconnier <guewen.baconnier@camptocamp.com>
+* Holger Brunn <hbrunn@terp.nl>
 * Jonathan Nemry <jonathan.nemry@acsone.eu>
 * Olivier Laurent <olivier.laurent@acsone.eu>
+* Sandy Carter <sandy.carter@savoirfairelinux.com>
+* Alexis de Lattre <alexis.delattre@akretion.fr>
+* Lorenzo Battistini <lorenzo.battistini@agilebg.com>
 * Hans Henrik Gabelgaard <hhg@gabelgaard.org>
 * Jairo Llopis <j.llopis@grupoesoc.es>
 * Adrien Peiffer <adrien.peiffer@acsone.eu>
+* Ronald Portier <ronald@therp.nl>
+* Sylvain Van Hoof
+* Pedro Baeza <pedro.baeza@serviciosbaeza.com>
+
+Translations
+------------
+
+* Danish: Hans Henrik Gabelgaard
+* Italian: Leonardo Donelli
+* Spanish: Antonio Espinosa
 
 Maintainer
 ----------

partner_firstname/__init__.py

@@ -1,21 +1,4 @@
 # -*- coding: utf-8 -*-
-
-#    Author: Nicolas Bessi. Copyright Camptocamp SA
-#    Copyright (C)
-#       2014:       Agile Business Group (<http://www.agilebg.com>)
-#       2015:       Grupo ESOC <www.grupoesoc.es>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
+# © 2013 Nicolas Bessi (Camptocamp SA)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 from . import models

partner_firstname/__openerp__.py

@@ -1,28 +1,14 @@
 # -*- coding: utf-8 -*-
-
-#    Author: Nicolas Bessi. Copyright Camptocamp SA
-#    Copyright (C)
-#       2014:       Agile Business Group (<http://www.agilebg.com>)
-#       2015:       Grupo ESOC <www.grupoesoc.es>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# © 2013 Nicolas Bessi (Camptocamp SA)
+# © 2014 Agile Business Group (<http://www.agilebg.com>)
+# © 2015 Grupo ESOC (<http://www.grupoesoc.es>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 {
     'name': 'Partner first name and last name',
     'summary': "Split first name and last name for non company partners",
-    'version': '8.0.2.1.0',
-    "author": "Camptocamp, "
+    'version': '9.0.1.0.0',
+    'author': "Camptocamp, "
               "Grupo ESOC Ingeniería de Servicios, "
               "Odoo Community Association (OCA)",
     "license": "AGPL-3",
@@ -39,6 +25,6 @@
     'demo': [],
     'test': [],
     'auto_install': False,
-    'installable': False,
+    'installable': True,
     'images': []
 }

partner_firstname/exceptions.py

@@ -1,20 +1,6 @@
 # -*- coding: utf-8 -*-
-# Odoo, Open Source Management Solution
-# Copyright (C) 2014-2015  Grupo ESOC <www.grupoesoc.es>
-#
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Affero General Public License for more details.
-#
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
+# © 2014-2015 Grupo ESOC (<http://www.grupoesoc.es>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 from openerp import _, exceptions
 
 

partner_firstname/models/__init__.py

@@ -0,0 +1,4 @@
+# -*- coding: utf-8 -*-
+# © 2013 Nicolas Bessi (Camptocamp SA)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from . import partner

partner_firstname/models.py → partner_firstname/models/partner.py

@@ -1,26 +1,11 @@
 # -*- coding: utf-8 -*-
-
-#    Author: Nicolas Bessi. Copyright Camptocamp SA
-#    Copyright (C)
-#       2014:       Agile Business Group (<http://www.agilebg.com>)
-#       2015:       Grupo ESOC <www.grupoesoc.es>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as
-#    published by the Free Software Foundation, either version 3 of the
-#    License, or (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU Affero General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
+# © 2013 Nicolas Bessi (Camptocamp SA)
+# © 2014 Agile Business Group (<http://www.agilebg.com>)
+# © 2015 Grupo ESOC (<http://www.grupoesoc.es>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 import logging
 from openerp import api, fields, models
-from . import exceptions
+from .. import exceptions
 
 
 _logger = logging.getLogger(__name__)
@@ -202,3 +187,12 @@ class ResPartner(models.Model):
         # Force calculations there
         records._inverse_name()
         _logger.info("%d partners updated installing module.", len(records))
+
+    # As name is computed after sql_constraint check, we modify it to accept
+    # to write when at least one name field is filled
+    _sql_constraints = [
+        ('check_name',
+         "CHECK( (type='contact' AND (name IS NOT NULL OR"
+         " firstname IS NOT NULL OR lastname IS NOT NULL)) or"
+         " (type!='contact') )", 'Contacts require a name.'),
+    ]

partner_firstname/views/res_partner.xml

@@ -15,7 +15,7 @@
                 }</attribute>
             </xpath>
 
-            <xpath expr="//field[@name='category_id']" position="before">
+            <xpath expr="//h1//field[@name='name']/.." position="before">
                 <group attrs="{'invisible': [('is_company', '=', True)]}">
                     <field name="lastname" attrs=
                         "{'required': [('firstname', '=', False),
@@ -42,47 +42,20 @@
                 }</attribute>
             </xpath>
 
-            <xpath expr="//field[@name='category_id']" position="before">
-                <group attrs="{'invisible': [('is_company', '=', True)]}">
-                    <field name="lastname" attrs=
-                        "{'required': [('firstname', '=', False),
-                                       ('is_company', '=', False)]}"/>
-                    <field name="firstname" attrs=
-                        "{'required': [('lastname', '=', False),
-                                       ('is_company', '=', False)]}"/>
-                </group>
-            </xpath>
-
-            <!-- Modify inner contact form of child_ids -->
-            <xpath expr="//field[@name='child_ids']/form
-                         //field[@name='category_id']"
-                   position="before">
-                <group attrs="{'invisible': [('is_company', '=', True)]}">
-                    <field name="lastname" attrs=
-                        "{'required': [('firstname', '=', False),
-                                       ('is_company', '=', False)]}"/>
-                    <field name="firstname" attrs=
-                        "{'required': [('lastname', '=', False),
-                                       ('is_company', '=', False)]}"/>
-                </group>
-            </xpath>
-
-            <xpath expr="//field[@name='child_ids']/form
-                         //field[@name='category_id']"
-                   position="attributes">
-                <attribute name="style"/>
-            </xpath>
-
-            <xpath expr="//field[@name='child_ids']/form//label[@for='name']"
-                   position="before">
+            <xpath expr="//h1//field[@name='name']/.." position="after">
                 <div class="oe_edit_only">
-                    <field name="is_company"
-                           on_change="onchange_type(is_company)"/>
-                    <label for="is_company"
-                           string="Is a Company?"/>
+                  <group attrs="{'invisible': [('is_company', '=', True)]}">
+                      <field name="lastname" attrs=
+                          "{'required': [('firstname', '=', False),
+                                         ('is_company', '=', False)]}"/>
+                      <field name="firstname" attrs=
+                          "{'required': [('lastname', '=', False),
+                                         ('is_company', '=', False)]}"/>
+                  </group>
                 </div>
             </xpath>
 
+            <!-- Modify inner contact form of child_ids -->
             <xpath expr="//field[@name='child_ids']/form//field[@name='name']"
                    position="attributes">
                 <attribute name="attrs">{
@@ -90,6 +63,21 @@
                     'required': [('is_company', '=', True)]
                 }</attribute>
             </xpath>
+
+            <xpath expr="//field[@name='child_ids']/form//field[@name='name']"
+                   position="after">
+                <div class="oe_edit_only" colspan="2">
+                  <field name="is_company" invisible="True"/>
+                  <group attrs="{'invisible': [('is_company', '=', True)]}">
+                      <field name="lastname" attrs=
+                          "{'required': [('firstname', '=', False),
+                                         ('is_company', '=', False)]}"/>
+                      <field name="firstname" attrs=
+                          "{'required': [('lastname', '=', False),
+                                         ('is_company', '=', False)]}"/>
+                  </group>
+                </div>
+            </xpath>
         </data>
   </field>
 </record>

partner_firstname/views/res_user.xml

@@ -4,7 +4,7 @@
 
 <!-- Required before modifying `base.vew_users_form`.
      https://github.com/odoo/odoo/issues/6324#issuecomment-93534579 -->
-<function model="res.groups" name="update_user_groups_view" />
+<!--<function model="res.groups" name="update_user_groups_view" />-->
 
 <record id="view_users_form" model="ir.ui.view">
     <field name="name">Add firstname and surnames</field>