This unittest was added to ensure that, after pressing on 'Recalculate Names'
button in 'partner_names_order' setting:
1 - firstname, lastname and lastname2 fields are not modified, and
2 - name field is computed correctly.
not firstname
before this commit the following error happen:
name = 'Van-Eyck Jan'
this was converted to
firstname = False
lastname= 'Van-Eyck'
lastname2 = 'Jan'
and it should be like
firstname = 'Jan'
lastname= 'Van-Eyck'
lastname2 = False
Description of the issue/feature this PR addresses:
firstname, lastname and lastname2 fields should only be required if
contact `type` is `contact`. In partner_firstname module this is done
right with `('type', '=', 'contact')` leave in attrs required domain.
But in partner_second_last_name there is no such leave, so if the
contact is an address, the fields are mandatory too.
Current behavior:
Either firstname, lastname or lastname2 are mandatory when a contact is
not a company.
Desired behavior after PR is merged:
firstname, lastname or lastname2 are mandatory when the contact is of
type `contact`
Bole
OCA-git-bot
payen000
Sergio Zanchetta
oca-travis
Luis Torres
Hugo Adan
emagdalena
Peter Schubert
Nikul-Chaudhary
Jon Zaballa
Rudolf Schnapka
Jordi Ballester
Pedro M. Baeza
Antonio Espinosa
Jairo Llopis