Browse Source

[FIX] base_comment_template: Filter domain correctly

1. Safe eval domain before checking if it is defined. This makes [] be "False" on the first check, and provides the proper use case for when the domain is empty
2. Use filtered_domain in record instead of a search in self. When on a compute, we are on a NewId context, so the search would always fail

TT29309
myc-14.0-py3o
João Marques 4 years ago
parent
commit
fee0f18049
  1. 5
      base_comment_template/models/comment_template.py

5
base_comment_template/models/comment_template.py

@ -39,7 +39,6 @@ class CommentTemplate(models.AbstractModel):
] ]
) )
for template in templates: for template in templates:
if not template.domain or self in self.search(
safe_eval(template.domain)
):
domain = safe_eval(template.domain)
if not domain or record.filtered_domain(domain):
record.comment_template_ids = [(4, template.id)] record.comment_template_ids = [(4, template.id)]
Loading…
Cancel
Save