From 2d3a9fb97c8f2294e1d4669fc3d2d113a5f300b8 Mon Sep 17 00:00:00 2001 From: Sandy Carter Date: Thu, 17 Jul 2014 07:20:58 -0400 Subject: [PATCH] Tighten type check in domain (closes #15) --- mass_editing/mass_editing.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mass_editing/mass_editing.py b/mass_editing/mass_editing.py index 9f7245743..7bc16e343 100644 --- a/mass_editing/mass_editing.py +++ b/mass_editing/mass_editing.py @@ -32,10 +32,11 @@ class ir_model_fields(orm.Model): count=False): model_domain = [] for domain in args: - if domain[0] == 'model_id' and domain[2]\ - and type(domain[2]) != list: - model_domain += [( - 'model_id', 'in', map(int, domain[2][1:-1].split(',')))] + if (len(domain) > 2 and domain[0] == 'model_id' + and isinstance(domain[2], basestring)): + model_domain += [ + ('model_id', 'in', map(int, domain[2][1:-1].split(','))) + ] else: model_domain.append(domain) return super(ir_model_fields, self).search(