From 433c1410843c8ec9490b482ad78d08dd673ea059 Mon Sep 17 00:00:00 2001
From: Holger Brunn <hbrunn@therp.nl>
Date: Tue, 11 Dec 2018 11:01:31 +0100
Subject: [PATCH] [FIX] linting issues

---
 auth_dynamic_groups/__openerp__.py      | 1 +
 auth_dynamic_groups/model/res_groups.py | 2 +-
 auth_dynamic_groups/model/res_users.py  | 6 ++++--
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/auth_dynamic_groups/__openerp__.py b/auth_dynamic_groups/__openerp__.py
index e713e67f8..dc9d59fd3 100644
--- a/auth_dynamic_groups/__openerp__.py
+++ b/auth_dynamic_groups/__openerp__.py
@@ -22,6 +22,7 @@
     "name": "Dynamic groups",
     "version": "8.0.1.0.0",
     "author": "Therp BV",
+    "license": "AGPL-3",
     "complexity": "normal",
     'summary': 'Have membership conditions for certain groups',
     "category": "Tools",
diff --git a/auth_dynamic_groups/model/res_groups.py b/auth_dynamic_groups/model/res_groups.py
index 59b6fa6a4..abc88c5e5 100644
--- a/auth_dynamic_groups/model/res_groups.py
+++ b/auth_dynamic_groups/model/res_groups.py
@@ -23,7 +23,7 @@ from openerp.tools.safe_eval import safe_eval
 from openerp import _
 
 
-class res_groups(models.Model):
+class ResGroups(models.Model):
     _inherit = 'res.groups'
 
     is_dynamic = fields.Boolean('Dynamic')
diff --git a/auth_dynamic_groups/model/res_users.py b/auth_dynamic_groups/model/res_users.py
index bcfd2d0ad..baffbf39c 100644
--- a/auth_dynamic_groups/model/res_users.py
+++ b/auth_dynamic_groups/model/res_users.py
@@ -22,11 +22,11 @@ from openerp.models import Model
 from openerp import SUPERUSER_ID
 
 
-class res_users(Model):
+class ResUsers(Model):
     _inherit = 'res.users'
 
     def _login(self, db, login, password):
-        uid = super(res_users, self)._login(db, login, password)
+        uid = super(ResUsers, self)._login(db, login, password)
 
         if uid and uid != SUPERUSER_ID:
             self.update_dynamic_groups(uid, db)
@@ -53,6 +53,8 @@ class res_users(Model):
                         '(%s, %s)',
                         (uid, dynamic_group.id))
             self.invalidate_cache(cr, uid, ['groups_id'], [uid])
+            # we really need a new transaction
+            # pylint: disable=invalid-commit
             cr.commit()
         finally:
             cr.close()