From 98a40f4b4c33552867b28e684dbd81ba0541a968 Mon Sep 17 00:00:00 2001
From: David Beal <david.beal@akretion.com>
Date: Tue, 16 Aug 2016 17:55:13 +0200
Subject: [PATCH] [FIX] security

---
 secure_uninstall/models/module.py      | 4 +++-
 secure_uninstall/views/module_view.xml | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/secure_uninstall/models/module.py b/secure_uninstall/models/module.py
index 4282b8d29..85283e03d 100644
--- a/secure_uninstall/models/module.py
+++ b/secure_uninstall/models/module.py
@@ -11,7 +11,7 @@ class BaseModuleUpgrade(models.TransientModel):
     _inherit = 'base.module.upgrade'
 
     password = fields.Char(
-        string='Password', required=True,
+        string='Password',
         help="'admin_passwd' value from Odoo configuration file "
              "(aka 'Master Password')")
 
@@ -35,4 +35,6 @@ class BaseModuleUpgrade(models.TransientModel):
                     "\n\nResolution\n-------------\n"
                     "Please check your password and retry or cancel"
                     % elm.password)
+            # keep this password in db is insecure, then we remove it
+            elm.password = False
         return super(BaseModuleUpgrade, self).upgrade_module()
diff --git a/secure_uninstall/views/module_view.xml b/secure_uninstall/views/module_view.xml
index 6e0391baa..66b51ca01 100644
--- a/secure_uninstall/views/module_view.xml
+++ b/secure_uninstall/views/module_view.xml
@@ -13,7 +13,7 @@
                 <label string="If you want uninstall module, write required password."
                        colspan="4" />
                 <group col="4">
-                    <field name="password" password="True"/>
+                    <field name="password" password="True" attrs="{'required': 1}"/>
                     <span/>
                 </group>
             </field>