Browse Source

[FIX] don't destroy values when there are empty default properties

pull/1506/head
Holger Brunn 6 years ago
parent
commit
c5f8e18b4d
No known key found for this signature in database GPG Key ID: 1C9760FECA3AE18
  1. 11
      database_cleanup/models/purge_properties.py

11
database_cleanup/models/purge_properties.py

@ -4,6 +4,7 @@
from odoo import api, models, fields from odoo import api, models, fields
REASON_DUPLICATE = 1 REASON_DUPLICATE = 1
REASON_DEFAULT = 2 REASON_DEFAULT = 2
REASON_DEFAULT_FALSE = 3
class CleanupPurgeLineProperty(models.TransientModel): class CleanupPurgeLineProperty(models.TransientModel):
@ -17,6 +18,7 @@ class CleanupPurgeLineProperty(models.TransientModel):
reason = fields.Selection([ reason = fields.Selection([
(REASON_DUPLICATE, 'Duplicated property'), (REASON_DUPLICATE, 'Duplicated property'),
(REASON_DEFAULT, 'Same value as default'), (REASON_DEFAULT, 'Same value as default'),
(REASON_DEFAULT_FALSE, 'Empty default property'),
]) ])
@api.multi @api.multi
@ -42,6 +44,15 @@ class CleanupPurgeWizardProperty(models.TransientModel):
]) ])
handled_field_ids = [] handled_field_ids = []
for prop in default_properties: for prop in default_properties:
if not prop.get_by_record():
result.append({
'name': '%s@%s: %s' % (
prop.name, prop.res_id, prop.get_by_record()
),
'property_id': prop.id,
'reason': REASON_DEFAULT_FALSE,
})
continue
if prop.fields_id.id in handled_field_ids: if prop.fields_id.id in handled_field_ids:
continue continue
domain = [ domain = [

Loading…
Cancel
Save