From df9c6cb72745a5ca6d563aab1703c095cb5c32f8 Mon Sep 17 00:00:00 2001 From: Sylvain LE GAL Date: Tue, 9 Jul 2019 21:07:00 +0200 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: David Beal --- module_analysis/README.rst | 2 +- module_analysis/models/ir_module_module.py | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/module_analysis/README.rst b/module_analysis/README.rst index db23145d6..b7defb1fb 100644 --- a/module_analysis/README.rst +++ b/module_analysis/README.rst @@ -106,7 +106,7 @@ files), create a custom modules and overload the module model : @api.model def _get_analyse_settings(self): - res = super(IrModuleModule, self)._get_analyse_settings() + res = super()._get_analyse_settings() if not '.html' in res: res['.html'] = {} res['.html']['documentation'] 'xml_documentation_qty' diff --git a/module_analysis/models/ir_module_module.py b/module_analysis/models/ir_module_module.py index b0418fcc4..45fd41adf 100644 --- a/module_analysis/models/ir_module_module.py +++ b/module_analysis/models/ir_module_module.py @@ -3,12 +3,9 @@ # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). import os -# import json import pygount from pathlib import Path import logging -# import os -# import subprocess from odoo import api, fields, models from odoo.tools.safe_eval import safe_eval @@ -83,14 +80,14 @@ class IrModuleModule(models.Model): # Overload Section @api.model def update_list(self): - res = super(IrModuleModule, self).update_list() + res = super().update_list() if self.env.context.get('analyse_installed_modules', False): self.search([('state', '=', 'installed')]).button_analyse_code() return res @api.multi def write(self, vals): - res = super(IrModuleModule, self).write(vals) + res = super().write(vals) if vals.get('state', False) == 'installed': self.button_analyse_code() elif vals.get('state', False) == 'uninstalled'\