From 0bac0a898e0db7329c23faea47e124a3bf072d20 Mon Sep 17 00:00:00 2001 From: Holger Brunn Date: Thu, 11 Jun 2015 14:21:39 +0200 Subject: [PATCH 1/2] [FIX] ie related fields don't have an ir.model.fields entry --- auditlog/models/rule.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/auditlog/models/rule.py b/auditlog/models/rule.py index 4a67b78cd..03962cc8f 100644 --- a/auditlog/models/rule.py +++ b/auditlog/models/rule.py @@ -389,9 +389,10 @@ class auditlog_rule(models.Model): if field_name in FIELDS_BLACKLIST: continue field = self._get_field(log.model_id, field_name) - log_vals = self._prepare_log_line_vals_on_write( - log, field, old_values, new_values) - log_line_model.create(log_vals) + if field: + log_vals = self._prepare_log_line_vals_on_write( + log, field, old_values, new_values) + log_line_model.create(log_vals) def _prepare_log_line_vals_on_write( self, log, field, old_values, new_values): @@ -434,9 +435,10 @@ class auditlog_rule(models.Model): if field_name in FIELDS_BLACKLIST: continue field = self._get_field(log.model_id, field_name) - log_vals = self._prepare_log_line_vals_on_create( - log, field, new_values) - log_line_model.create(log_vals) + if field: + log_vals = self._prepare_log_line_vals_on_create( + log, field, new_values) + log_line_model.create(log_vals) def _prepare_log_line_vals_on_create(self, log, field, new_values): """Prepare the dictionary of values used to create a log line on a From f4e51c6751362ab170780a67222fa5055351c0d2 Mon Sep 17 00:00:00 2001 From: Holger Brunn Date: Wed, 8 Jul 2015 12:47:53 +0200 Subject: [PATCH 2/2] [ADD] comment --- auditlog/models/rule.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/auditlog/models/rule.py b/auditlog/models/rule.py index 03962cc8f..67acb7a81 100644 --- a/auditlog/models/rule.py +++ b/auditlog/models/rule.py @@ -358,6 +358,7 @@ class auditlog_rule(models.Model): if field_name in FIELDS_BLACKLIST: continue field = self._get_field(log.model_id, field_name) + # not all fields have an ir.models.field entry (ie. related fields) if field: log_vals = self._prepare_log_line_vals_on_read( log, field, read_values) @@ -389,6 +390,7 @@ class auditlog_rule(models.Model): if field_name in FIELDS_BLACKLIST: continue field = self._get_field(log.model_id, field_name) + # not all fields have an ir.models.field entry (ie. related fields) if field: log_vals = self._prepare_log_line_vals_on_write( log, field, old_values, new_values) @@ -435,6 +437,7 @@ class auditlog_rule(models.Model): if field_name in FIELDS_BLACKLIST: continue field = self._get_field(log.model_id, field_name) + # not all fields have an ir.models.field entry (ie. related fields) if field: log_vals = self._prepare_log_line_vals_on_create( log, field, new_values)