From d0866738d0c3c2bcb192bedf8973fb61b043fbd8 Mon Sep 17 00:00:00 2001 From: David Date: Fri, 22 Dec 2017 19:23:40 +0100 Subject: [PATCH 1/2] [10.0][FIX] mail_tracking_mailgun: Avoid key dict errors --- mail_tracking_mailgun/models/mail_tracking_email.py | 6 ++++-- mail_tracking_mailgun/models/res_partner.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/mail_tracking_mailgun/models/mail_tracking_email.py b/mail_tracking_mailgun/models/mail_tracking_email.py index e2d557de..8662e135 100644 --- a/mail_tracking_mailgun/models/mail_tracking_email.py +++ b/mail_tracking_mailgun/models/mail_tracking_email.py @@ -9,7 +9,7 @@ import json import requests from datetime import datetime from openerp import _, api, fields, models -from openerp.exceptions import ValidationError +from openerp.exceptions import UserError, ValidationError import logging _logger = logging.getLogger(__name__) @@ -221,6 +221,8 @@ class MailTrackingEmail(models.Model): """ api_key, api_url, domain, validation_key = self._mailgun_values() for tracking in self: + if not tracking.mail_message_id: + raise UserError(_('There is no tracked message!')) message_id = tracking.mail_message_id.message_id.replace( "<", "").replace(">", "") res = requests.get( @@ -242,7 +244,7 @@ class MailTrackingEmail(models.Model): if not self.env['mail.tracking.event'].search( [('mailgun_id', '=', item["id"])]): mapped_event_type = self._mailgun_event_type_mapping.get( - item["event"]) or False + item["event"], item["event"]) metadata = self._mailgun_metadata( mapped_event_type, item, {}) tracking.event_create(mapped_event_type, metadata) diff --git a/mail_tracking_mailgun/models/res_partner.py b/mail_tracking_mailgun/models/res_partner.py index 9657647c..1c8779cb 100644 --- a/mail_tracking_mailgun/models/res_partner.py +++ b/mail_tracking_mailgun/models/res_partner.py @@ -30,7 +30,7 @@ class ResPartner(models.Model): body = _('Email has been bounced: %s\n' 'Reason: %s\n' 'Event: %s') % (partner.email, reason, - event['Message-Id'] or '') + event.get('Message-Id', _('unknown'))) partner.message_post(body=body) @api.multi From d3623da7594674d78135aeb72c09d2b80ea9536e Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Mon, 15 Jan 2018 13:00:28 +0000 Subject: [PATCH 2/2] [FIX] mail_tracking_mailgun: Avoid errors without event When this method is called without an event (a.k.a. `event=None`), this method produces the following error: ``` Traceback (most recent call last): File "/opt/odoo/auto/addons/mail/models/mail_mail.py", line 278, in send res = IrMailServer.send_email(msg, mail_server_id=mail.mail_server_id.id) File "/opt/odoo/auto/addons/mail_tracking/models/ir_mail_server.py", line 88, in send_email tracking_email.smtp_error(self, smtp_server_used, e) File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 213, in smtp_error self.sudo()._partners_email_bounced_set('error') File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 203, in _partners_email_bounced_set ]).email_bounced_set(self, reason, event=event) File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 22, in email_bounced_set self._email_bounced_set(reason, event) File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 33, in _email_bounced_set event['Message-Id'] or '') TypeError: 'NoneType' object has no attribute '__getitem__' ``` So, we now assume we do not always have an event. --- mail_tracking_mailgun/models/res_partner.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mail_tracking_mailgun/models/res_partner.py b/mail_tracking_mailgun/models/res_partner.py index 1c8779cb..1d138e9a 100644 --- a/mail_tracking_mailgun/models/res_partner.py +++ b/mail_tracking_mailgun/models/res_partner.py @@ -30,7 +30,8 @@ class ResPartner(models.Model): body = _('Email has been bounced: %s\n' 'Reason: %s\n' 'Event: %s') % (partner.email, reason, - event.get('Message-Id', _('unknown'))) + event and event.get('Message-Id', + _('unknown'))) partner.message_post(body=body) @api.multi