From 12be6d2b4be2d1666aa66c339aa66e49bfbcd8ae Mon Sep 17 00:00:00 2001
From: jesusVMayor <jesus@comunitea.com>
Date: Tue, 30 May 2017 13:27:24 +0200
Subject: [PATCH] [IMP] web_m2x_options: Perf issue
 https://github.com/OCA/web/issues/615 * fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
---
 web_m2x_options/static/src/js/form.js | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/web_m2x_options/static/src/js/form.js b/web_m2x_options/static/src/js/form.js
index 13ec3a6e..fb46f274 100644
--- a/web_m2x_options/static/src/js/form.js
+++ b/web_m2x_options/static/src/js/form.js
@@ -111,7 +111,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
             if (_.isUndefined(this.view))
                     return this._super.apply(this, arguments);
                 if (!_.isUndefined(this.view.ir_options['web_m2x_options.limit'])) {
-                this.limit = parseInt(this.view.ir_options['web_m2x_options.limit']);
+                this.limit = parseInt(this.view.ir_options['web_m2x_options.limit'], 10);
             }
 
             if (typeof this.options.limit === 'number') {
@@ -134,13 +134,14 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                 'ilike', this.limit + 1,
                 self.build_context()));
 
-            var create_rights;
             if (!(self.options && (self.is_option_set(self.options.create) || self.is_option_set(self.options.create_edit)))) {
-                create_rights = new Model(this.field.relation).call(
+                this.create_rights = this.create_rights || (function(){
+                return new Model(self.field.relation).call(
                     "check_access_rights", ["create", false]);
+                })();
             }
 
-            $.when(search_result, create_rights).then(function (data, can_create) {
+            $.when(search_result, this.create_rights).then(function (data, can_create) {
 
                 self.can_create = can_create;  // for ``.show_error_displayer()``
                 self.last_search = data;
@@ -200,7 +201,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                                     self._search_create_popup("search", data);
                                 });
                         },
-                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option' 
+                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option'
                     });
                 }
 
@@ -225,7 +226,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                             action: function () {
                                 self._quick_create(search_val);
                             },
-                            classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option' 
+                            classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option'
                         });
                     }
                 }
@@ -244,7 +245,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                                 "form", undefined,
                                 self._create_context(search_val));
                         },
-                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option' 
+                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option'
                     });
                 }
                 // Check if colors specified to wait for RPC
@@ -316,7 +317,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
             // returned.
 
             if (!_.isUndefined(this.view.ir_options['web_m2x_options.limit'])) {
-                this.limit = parseInt(this.view.ir_options['web_m2x_options.limit']);
+                this.limit = parseInt(this.view.ir_options['web_m2x_options.limit'], 10);
             }
 
             if (typeof this.options.limit === 'number') {
@@ -356,7 +357,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                                 self._search_create_popup("search", data);
                             });
                         },
-                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option' 
+                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option'
                     });
                 }
                 // quick create
@@ -375,7 +376,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                             action: function() {
                                 self._quick_create(search_val);
                             },
-                            classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option' 
+                            classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option'
                         });
                     }
                 }
@@ -393,7 +394,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
                         action: function() {
                             self._search_create_popup("form", undefined, self._create_context(search_val));
                         },
-                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option' 
+                        classname: 'oe_m2o_dropdown_option o_m2o_dropdown_option'
                     });
                 }
 
@@ -406,7 +407,7 @@ odoo.define('web_m2x_options.web_m2x_options', function (require) {
             var open = (self.options && self.is_option_set(self.options.open));
             if(open){
                 self.mutex.exec(function(){
-                    var id = parseInt($(ev.currentTarget).data('id'));
+                    var id = parseInt($(ev.currentTarget).data('id'), 10);
                     self.do_action({
                         type: 'ir.actions.act_window',
                         res_model: self.field.relation,