Browse Source

[FIX] flake8 and RST corrections according to code review

pull/144/head
Damien Crier 9 years ago
parent
commit
368e214927
  1. 22
      web_warning_on_save/README.rst
  2. 5
      web_warning_on_save/controller.py

22
web_warning_on_save/README.rst

@ -5,8 +5,14 @@ Raise warning when saving
========================= =========================
This module was written to extend the functionality of saving a record in the web interface. This module was written to extend the functionality of saving a record in the web interface.
/!\/!\/!\ In no way this module stops the save of the record. You must consider this as a warning displayed
to the user AFTER save completed. /!\/!\/!\
/!\\/!\\/!\\
In no way this module stops the save of the record. You must consider this as a warning displayed
to the user AFTER save completed.
/!\\/!\\/!\\
If you don't want OpenERP to save the record, you should use constraints. If you don't want OpenERP to save the record, you should use constraints.
Usage Usage
@ -18,16 +24,18 @@ To use this module, you need to:
example : example :
def check_warning_on_save(self, cr, uid, id, context=None):
.. code:: python
def check_warning_on_save(self, cr, uid, id, context=None):
""" """
@param: int: record_id @param: int: record_id
@return: string: message that should be displayed to the user @return: string: message that should be displayed to the user
""" """
res = "" res = ""
record = self.browse(cr, uid, id, context=context) record = self.browse(cr, uid, id, context=context)
# ... make some checks
# ... make some checks
return res return res
For further information, please visit: For further information, please visit:
@ -41,7 +49,7 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/{project_repo}/issues>`_. Bugs are tracked on `GitHub Issues <https://github.com/OCA/{project_repo}/issues>`_.
In case of trouble, please check there if your issue has already been reported. In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed feedback If you spotted it first, help us smashing it by providing a detailed and welcomed feedback
`here <https://github.com/OCA/{project_repo}/issues/new?body=module:%20{module_name}%0Aversion:%20{version}%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`here <https://github.com/OCA/web/issues/new?body=module:%20web_warning_on_save%0Aversion:%207.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
Credits Credits

5
web_warning_on_save/controller.py

@ -20,11 +20,9 @@
############################################################################## ##############################################################################
import xmlrpclib import xmlrpclib
import openerp import openerp
class WarningOnSaveController(openerp.addons.web.http.Controller): class WarningOnSaveController(openerp.addons.web.http.Controller):
_cp_path = "/web_warning_on_save" _cp_path = "/web_warning_on_save"
@ -42,5 +40,4 @@ class WarningOnSaveController(openerp.addons.web.http.Controller):
if 'AttributeError' in e.faultString: if 'AttributeError' in e.faultString:
return False return False
else: else:
raise openerp.osv.osv.except_osv('Error', e.faultCode)
raise openerp.osv.osv.except_osv('Error', e.faultCode)
Loading…
Cancel
Save