From 88e68cf513e8e3764e98732cb002a08936f7dec3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Houz=C3=A9fa=20Abbasbhay?= Date: Fri, 4 Aug 2017 10:56:59 +0200 Subject: [PATCH] [10.0][FIX] web_notify tests: Fix an arg check Fix a check when comparing a user count with items within a mock call. The previous method was succeeding by pure luck because OCA test databases contain 2 users, which happens to be the amount of items within a mock "call_args" (it contains args + kwargs). --- web_notify/tests/test_res_users.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/web_notify/tests/test_res_users.py b/web_notify/tests/test_res_users.py index a6f8087f..72416d5e 100644 --- a/web_notify/tests/test_res_users.py +++ b/web_notify/tests/test_res_users.py @@ -47,5 +47,15 @@ class TestResUsers(common.TransactionCase): users = self.env.user.search([(1, "=", 1)]) self.assertTrue(len(users) > 1) users.notify_warning('message') + self.assertEqual(1, mockedSendMany.call_count) - self.assertEqual(len(users), len(mockedSendMany.call_args)) + + # call_args is a tuple with args (tuple) & kwargs (dict). We check + # positional arguments (args), hence the [0]. + pos_call_args = mockedSendMany.call_args[0] + + # Ensure the first positional argument is a list with as many + # elements as we had users. + first_pos_call_args = pos_call_args[0] + self.assertIsInstance(first_pos_call_args, list) + self.assertEqual(len(users), len(first_pos_call_args))