From d4e6881724142e7cd5ef688012b0dc65dd5cb1f2 Mon Sep 17 00:00:00 2001 From: George Daramouskas Date: Fri, 8 Mar 2019 11:02:38 +0100 Subject: [PATCH] [FIX] web_drop_target Make sure that when a File is dropped into a form the event is propagated and the action only takes place when the element dropped is actually a Blob object --- web_drop_target/static/src/js/web_drop_target.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web_drop_target/static/src/js/web_drop_target.js b/web_drop_target/static/src/js/web_drop_target.js index 165e71cb..27099d05 100644 --- a/web_drop_target/static/src/js/web_drop_target.js +++ b/web_drop_target/static/src/js/web_drop_target.js @@ -26,7 +26,7 @@ odoo.define('web_drop_target', function(require) { _on_drop: function(e) { var drop_item = this._get_drop_item(e); - if(!drop_item) { + if(!drop_item || !(drop_item.getAsFile() instanceof Blob)) { return; } jQuery(e.delegateTarget).removeClass(this._drag_over_class); @@ -35,6 +35,7 @@ odoo.define('web_drop_target', function(require) { _.partial(this._handle_file_drop, drop_item.getAsFile()) ); reader.readAsArrayBuffer(drop_item.getAsFile()); + e.stopPropagation(); e.preventDefault(); },