From 094804c2fe281d96c92915c335296471f7efb602 Mon Sep 17 00:00:00 2001 From: "devang@dreambits" Date: Thu, 2 Aug 2018 19:41:50 +0530 Subject: [PATCH 1/3] [FIX] fixed issue for chrome; now, for unsaved data, it displays dialog of warning --- .../static/src/js/web_confirm_window_close.js | 1 + 1 file changed, 1 insertion(+) diff --git a/web_confirm_window_close/static/src/js/web_confirm_window_close.js b/web_confirm_window_close/static/src/js/web_confirm_window_close.js index 3aba9f97..61594274 100644 --- a/web_confirm_window_close/static/src/js/web_confirm_window_close.js +++ b/web_confirm_window_close/static/src/js/web_confirm_window_close.js @@ -10,6 +10,7 @@ odoo.define('web_confirm_window_close', function (require) { if ($('html').find('.oe_form_dirty').length) { e.preventDefault(); } + return 'Your have unsaved data. Are you sure you want to close window?'; }, start: function() { From 57cbc7bdc178522a8049cab6753c04c8610b84ee Mon Sep 17 00:00:00 2001 From: "devang@dreambits" Date: Fri, 3 Aug 2018 12:47:00 +0530 Subject: [PATCH 2/3] [UPDATE] added auther information for fixmade for #727 --- web_confirm_window_close/README.rst | 1 + web_confirm_window_close/__manifest__.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/web_confirm_window_close/README.rst b/web_confirm_window_close/README.rst index b1e834f9..4183dcd2 100644 --- a/web_confirm_window_close/README.rst +++ b/web_confirm_window_close/README.rst @@ -42,6 +42,7 @@ Images Contributors ------------ +* Devang Pipaliya * Stefan Rijnhart Maintainer diff --git a/web_confirm_window_close/__manifest__.py b/web_confirm_window_close/__manifest__.py index 65acab14..f527529e 100644 --- a/web_confirm_window_close/__manifest__.py +++ b/web_confirm_window_close/__manifest__.py @@ -4,7 +4,7 @@ { 'name': 'Check for unsaved data when closing browser window', 'version': '10.0.1.0.0', - 'author': "Therp BV,Odoo Community Association (OCA)", + 'author': "Devang Pipaliya - Dreambits,Therp BV,Odoo Community Association (OCA)", 'category': 'Usability', 'website': 'https://github.com/oca/web', 'license': 'AGPL-3', From 1ed2f4a12de392c3e5c891afede174078b5b3024 Mon Sep 17 00:00:00 2001 From: "devang@dreambits" Date: Fri, 3 Aug 2018 19:38:47 +0530 Subject: [PATCH 3/3] [UPDATE] make return stamtent blank as no effect of any custom message on beforeunload event --- .../static/src/js/web_confirm_window_close.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_confirm_window_close/static/src/js/web_confirm_window_close.js b/web_confirm_window_close/static/src/js/web_confirm_window_close.js index 61594274..3b9c6cd1 100644 --- a/web_confirm_window_close/static/src/js/web_confirm_window_close.js +++ b/web_confirm_window_close/static/src/js/web_confirm_window_close.js @@ -10,7 +10,7 @@ odoo.define('web_confirm_window_close', function (require) { if ($('html').find('.oe_form_dirty').length) { e.preventDefault(); } - return 'Your have unsaved data. Are you sure you want to close window?'; + return ""; }, start: function() {