From 4f01fdea060ee3059e1f5e3e1435e6f625326545 Mon Sep 17 00:00:00 2001
From: "robin.keunen" <robin@keunen.net>
Date: Fri, 7 Feb 2020 17:09:45 +0100
Subject: [PATCH] [REF] easy_my_coop: todos

---
 easy_my_coop/models/coop.py                      | 12 ++++++++----
 easy_my_coop/views/subscription_request_view.xml |  2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/easy_my_coop/models/coop.py b/easy_my_coop/models/coop.py
index cd697dd..62b43be 100644
--- a/easy_my_coop/models/coop.py
+++ b/easy_my_coop/models/coop.py
@@ -29,6 +29,7 @@ def _lang_get(self):
     return [(language.code, language.name) for language in languages]
 
 
+# todo move to subscription_request.py
 class SubscriptionRequest(models.Model):
     _name = 'subscription.request'
     _description = 'Subscription Request'
@@ -535,6 +536,7 @@ class SubscriptionRequest(models.Model):
 
     @api.one  # todo remove api.one
     def validate_subscription_request(self):
+        # todo rename to validate (careful with iwp dependencies)
         partner_obj = self.env['res.partner']
 
         if self.ordered_parts <= 0:
@@ -593,25 +595,26 @@ class SubscriptionRequest(models.Model):
 
         return invoice
 
-    @api.one
+    @api.one  # todo remove api.one
     def block_subscription_request(self):
         self.write({'state': 'block'})
 
-    @api.one
+    @api.one  # todo remove api.one
     def unblock_subscription_request(self):
         self.write({'state': 'draft'})
 
-    @api.one
+    @api.one  # todo remove api.one
     def cancel_subscription_request(self):
         self.write({'state': 'cancelled'})
 
-    @api.one
+    @api.one  # todo remove api.one
     def put_on_waiting_list(self):
         waiting_list_mail_template = self.env.ref('easy_my_coop.email_template_waiting_list', False)
         waiting_list_mail_template.send_mail(self.id, True)
         self.write({'state': 'waiting'})
 
 
+# todo move to share_line.py
 class ShareLine(models.Model):
     _name = 'share.line'
     _description = "Share line"
@@ -665,6 +668,7 @@ class ShareLine(models.Model):
     )
 
 
+# todo move to subscription_register.py
 class SubscriptionRegister(models.Model):
     _name = 'subscription.register'
     _description = "Subscription register"
diff --git a/easy_my_coop/views/subscription_request_view.xml b/easy_my_coop/views/subscription_request_view.xml
index 96197e0..1f66951 100644
--- a/easy_my_coop/views/subscription_request_view.xml
+++ b/easy_my_coop/views/subscription_request_view.xml
@@ -33,7 +33,7 @@
         <field name="arch" type="xml">
     		<form string="Subscription Requests">
    				<header>
-   					<button string="Validate" type="object" name="validate_subscription_request" attrs="{'invisible':['|',('state','not in',['draft','waiting']),('validated','=',False)]}"/>
+   					<button string="Validate" type="object" name="validate_subscription_request" states="draft,waiting,transfer" />
    					<button string="Waiting list" type="object" name="put_on_waiting_list" states="draft"/>
    					<button string="Cancel" type="object" name="cancel_subscription_request" states="draft,waiting,done,block" groups="easy_my_coop.group_easy_my_coop_user"/>
    					<field name="state" widget="statusbar" statusbar_visible="draft,cancelled,done,failed"/>