0k
/
0k-charms
6
3
Fork 2
Code Issues 11 Pull Requests 5 Releases Wiki Activity
Labels Milestones
New Pull Request

new: [rallly] new charm #32

Closed
bgallet wants to merge 1 commits from bgallet/0k-charms:boris/rallly into master
Conversation 1 Commits 1 Files Changed 6
bgallet commented 6 months ago
Collaborator

Demande d’ajout pour le charm "Rallly"

Fonctionne avec un autre charm smtp-extern

Demande d’ajout pour le charm "Rallly" Fonctionne avec un autre charm smtp-extern
bgallet added 1 commit 6 months ago
bgallet changed title from WIP: new: [rallly] new charm to new: [rallly] new charm 6 months ago
vlab commented 5 months ago
Owner

Many thanks !

Reviewed, tested, changed:

init
    remove || exit 1 in favor of a top set -e
    remove the invalid NEXT_PUBLIC_BASE_URL
    add a check of the docker version as test showed it required 20.10
metadata.yml
    provide the charm-resource to override the /app/docker-start.sh file allowing to set the NEXTPUBLICBASEURL dynamically to the current IP of the docker.
    remove backup declaration of usage. There's nothing to backup.
hooks/smtp_server-relation-joined
    rewrite to set rallly variables depending on the smtp-server relation variables.
hooks/web_proxy-relation-joined
    use relation-get url instead of domain and forcing https protocol.
resources/app/docker-start.sh
    add file to allow dynamical setting of URL

Testing:

local test (without any web-proxy)
tests on vps-03.0k.io: failed, this image is not compatible with older version of docker => added a check in init.
tests on vps-04.0k.io, ok

Notes:

This charm probably could be a subordinate, and be only 50M big instead of 1.2GB, and it wouldn't have the requirement on the host on the docker version.

It is based on debian 1

This was committed (#9598167) in master branch. Kept you as author.

Many thanks ! Reviewed, tested, changed: init remove || exit 1 in favor of a top set -e remove the invalid NEXT_PUBLIC_BASE_URL add a check of the docker version as test showed it required 20.10 metadata.yml provide the charm-resource to override the /app/docker-start.sh file allowing to set the NEXTPUBLICBASEURL dynamically to the current IP of the docker. remove backup declaration of usage. There's nothing to backup. hooks/smtp_server-relation-joined rewrite to set rallly variables depending on the smtp-server relation variables. hooks/web_proxy-relation-joined use relation-get url instead of domain and forcing https protocol. resources/app/docker-start.sh add file to allow dynamical setting of URL Testing: local test (without any web-proxy) tests on vps-03.0k.io: failed, this image is not compatible with older version of docker => added a check in init. tests on vps-04.0k.io, ok Notes: This charm probably could be a subordinate, and be only 50M big instead of 1.2GB, and it wouldn't have the requirement on the host on the docker version. It is based on debian 1 This was committed (#9598167) in master branch. Kept you as author.
vlab closed this pull request 5 months ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed win wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question win wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'bgallet/0k-charms:boris/rallly'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes