Add tests

7 years ago · a9fc5c1295
6 changed files with 263 additions and 1 deletions
--- a/account_bank_statement_import_mt940_base/README.rst
+++ b/account_bank_statement_import_mt940_base/README.rst
@ -35,6 +35,7 @@ Contributors

 * Stefan Rijnhart <srijnhart@therp.nl>
 * Ronald Portier <rportier@therp.nl>
+* Andrea Stirpe <a.stirpe@onestein.nl>

 Maintainer
 ----------
--- a/account_bank_statement_import_mt940_base/mt940.py
+++ b/account_bank_statement_import_mt940_base/mt940.py
@ -202,7 +202,7 @@ class MT940(object):
        """find a function to handle the record represented by line"""
        tag_match = re.match(self.tag_regex, line)
        tag = tag_match.group(0).strip(':')
-        if not hasattr(self, 'handle_tag_%s' % tag):
+        if not hasattr(self, 'handle_tag_%s' % tag):  # pragma: no cover
            logging.error('Unknown tag %s', tag)
            logging.error(line)
            return
--- a/account_bank_statement_import_mt940_base/test_files/test-ing.940
+++ b/account_bank_statement_import_mt940_base/test_files/test-ing.940
@ -0,0 +1,61 @@
+{1:F01INGBNL2ABXXX0000000000}
+{2:I940INGBNL2AXXXN}
+{4:
+:20:P140220000000001
+:25:NL77INGB0574908765EUR
+:28C:0000
+0
+:60F:C140219EUR662,23
+:61:1402200220C1,56NTRFEREF//00000000001
+005
+/TRCD/00100/
+:86:/EREF/EV12341REP1231456T1234//CNTP/NL32INGB0000012345/INGBNL2
+A/ING BANK NV INZAKE WEB///REMI/USTD//EV10001REP1000000T1000/
+:61:1402200220D1,57NTRFPREF//00000000001006
+/TRCD/00200/
+:86:/PREF/M000000003333333//REMI/USTD//TOTAAL 1 VZ/
+:61:1402200220C1,57NRTIEREF//00000000001007
+/TRCD/00190/
+:86:/RTRN/MS03//EREF/20120123456789//CNTP/NL32INGB0000012345/INGB
+NL2A/J.Janssen///REMI/USTD//Factuurnr 123456 Klantnr 00123/
+:61:1402200220D1,14NDDTEREF//00000000001009
+/TRCD/010
+16
+/
+:86:/EREF/EV123R
+EP123412T1234//MARF/MND
+-
+EV01//CSID/NL32ZZZ9999999
+91234//CNTP/NL32INGB0000012345/INGBNL2A/ING Bank N.V. inzake WeB/
+//REMI/USTD//EV123REP123412T1234/
+:61:1402200220C1,45NDDTPREF//00000000001008
+/TRCD/01000/
+:86:/PREF/M000000001111111/
+/CSID/
+NL32ZZZ999999991234
+/
+/REMI/USTD//
+TOTAAL 1 POSTEN/
+:61:1402200220D12,75NRTIEREF//00000000001010
+/TRCD/01315/
+:86:/RTRN/MS03//EREF/20120501P0123478//MARF/MND
+-
+120123//CSID/NL32
+ZZZ999999991234//CNTP/NL32INGB0000012345/INGBNL2A/J.Janssen///REM
+I/USTD//CO
+NTRIBUTIE FEB 2014/
+:61:1402200220C32,00NTRF9001123412341234//00000000001011
+/TRCD/00108/
+:86:/EREF/15814016000676480//CNTP/NL32INGB0000012345/INGBNL2A/J.J
+anssen///REMI/STRD/CUR/9001123412341234/
+:61:1402200220D119,00NTRF1070123412341234//00000000001012
+/
+TRCD/00108/
+:86:/EREF/15614016000384600//CNTP/NL32INGB0000012345/INGBNL2A/ING
+BANK NV///REMI/STRD/CUR/1070123412341234/
+:62F:C140220EUR564,35
+:64:C140220EUR564,35
+:65:C140221EUR564,35
+:65:C140224EUR564,35
+:86:/SUM/4/4/134,46/36,58/
+-}
--- a/account_bank_statement_import_mt940_base/test_files/test-rabo.swi
+++ b/account_bank_statement_import_mt940_base/test_files/test-rabo.swi
@ -0,0 +1,29 @@
+:940:
+:20:940S140102
+:25:NL34RABO0142623393 EUR
+:28C:0
+:60F:C131231EUR000000004433,52
+:61:140102C000000000400,00N541NONREF
+NL66RABO0160878799
+:86:/ORDP//NAME/R. SMITH/ADDR/Green market 74 3311BE Sheepcity Nederl
+and NL/REMI/Test money paid by other partner:
+/ISDT/2014-01-02
+:62F:C140102EUR000000004833,52
+:20:940S140103
+:25:NL34RABO0142623393 EUR
+:28C:0
+:60F:C140102EUR000000004833,52
+:62F:C140103EUR000000004833,52
+:20:940S140106
+:25:NL34RABO0142623393 EUR
+:28C:0
+:60F:C140103EUR000000004833,52
+:61:140101D000000000034,61N093NONREF
+:86:/BENM//NAME/Kosten/REMI/Periode 01-10-2013 t/m 31-12-2013/ISDT/20
+14-01-01
+:62F:C140106EUR000000004798,91
+:20:940S140107
+:25:NL34RABO0142623393 EUR
+:28C:0
+:60F:C140106EUR000000004798,91
+:62F:C140107EUR000000004798,91
--- a/account_bank_statement_import_mt940_base/tests/init.py
+++ b/account_bank_statement_import_mt940_base/tests/init.py
@ -0,0 +1 @@
+from . import test_import_bank_statement
--- a/account_bank_statement_import_mt940_base/tests/test_import_bank_statement.py
+++ b/account_bank_statement_import_mt940_base/tests/test_import_bank_statement.py
@ -0,0 +1,170 @@
+# -*- coding: utf-8 -*-
+# Copyright 2017 Onestein (<http://www.onestein.eu>)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+import base64
+from mock import patch
+from odoo.tests.common import TransactionCase
+from odoo.modules.module import get_module_resource
+from ..mt940 import MT940, get_subfields, handle_common_subfields
+
+
+class TestImport(TransactionCase):
+    """Run test to import mt940 import."""
+    transactions = [
+        {
+            'account_number': 'NL46ABNA0499998748',
+            'amount': -754.25,
+            'ref': '435005714488-ABNO33052620',
+            'name': 'test line',
+        },
+    ]
+
+    def setUp(self):
+        super(TestImport, self).setUp()
+        bank1 = self.env['res.partner.bank'].create({
+            'acc_number': 'NL77INGB0574908765',
+            'partner_id': self.env.ref('base.main_partner').id,
+            'company_id': self.env.ref('base.main_company').id,
+            'bank_id': self.env.ref('base.res_bank_1').id,
+        })
+        self.env['account.journal'].create({
+            'name': 'Bank Journal - (test1 mt940)',
+            'code': 'TBNK1MT940',
+            'type': 'bank',
+            'bank_account_id': bank1.id,
+            'currency_id': self.env.ref('base.EUR').id,
+        })
+        bank2 = self.env['res.partner.bank'].create({
+            'acc_number': 'NL34RABO0142623393',
+            'partner_id': self.env.ref('base.main_partner').id,
+            'company_id': self.env.ref('base.main_company').id,
+            'bank_id': self.env.ref('base.res_bank_1').id,
+        })
+        self.env['account.journal'].create({
+            'name': 'Bank Journal - (test2 mt940)',
+            'code': 'TBNK2MT940',
+            'type': 'bank',
+            'bank_account_id': bank2.id,
+            'currency_id': self.env.ref('base.EUR').id,
+        })
+
+        self.data =\
+            "/BENM//NAME/Cost/REMI/Period 01-10-2013 t/m 31-12-2013/ISDT/20"
+        self.codewords = ['BENM', 'ADDR', 'NAME', 'CNTP', 'ISDT', 'REMI']
+
+    def test_statement_import(self):
+        """Test correct creation of single statement."""
+
+        def _prepare_statement_lines(statements):
+            transact = self.transactions[0]
+            for st_vals in statements[2]:
+                for line_vals in st_vals['transactions']:
+                    line_vals['amount'] = transact['amount']
+                    line_vals['name'] = transact['name']
+                    line_vals['account_number'] = transact['account_number']
+                    line_vals['ref'] = transact['ref']
+
+        testfile = get_module_resource(
+            'account_bank_statement_import_mt940_base',
+            'test_files',
+            'test-ing.940',
+        )
+        parser = MT940()
+        datafile = open(testfile, 'rb').read()
+        statements = parser.parse(datafile)
+
+        _prepare_statement_lines(statements)
+
+        path_addon = 'odoo.addons.account_bank_statement_import.'
+        path_file = 'account_bank_statement_import.'
+        path_class = 'AccountBankStatementImport.'
+        method = path_addon + path_file + path_class + '_parse_file'
+        with patch(method) as my_mock:
+            my_mock.return_value = statements
+
+            action = self.env['account.bank.statement.import'].create({
+                'data_file': base64.b64encode(datafile),
+            }).import_file()
+
+            transact = self.transactions[0]
+            for statement in self.env['account.bank.statement'].browse(
+                action['context']['statement_ids']
+            ):
+                for line in statement.line_ids:
+                    self.assertTrue(
+                        line.bank_account_id.acc_number ==
+                        transact['account_number'])
+                    self.assertTrue(line.amount == transact['amount'])
+                    self.assertTrue(line.date == '2014-02-20')
+                    self.assertTrue(line.name == transact['name'])
+                    self.assertTrue(line.ref == transact['ref'])
+
+    def test_get_subfields(self):
+        """Unit Test function get_subfields()."""
+
+        res = get_subfields(self.data, self.codewords)
+        espected_res = {
+            'BENM': [''],
+            'NAME': ['Cost'],
+            'REMI': ['Period 01-10-2013 t', 'm 31-12-2013'],
+            'ISDT': ['20'],
+        }
+        self.assertTrue(res == espected_res)
+
+    def test_handle_common_subfields(self):
+        """Unit Test function handle_common_subfields()."""
+
+        subfields = get_subfields(self.data, self.codewords)
+        transaction = self.transactions[0]
+
+        handle_common_subfields(transaction, subfields)
+
+    def test_statement_import2(self):
+        """Test correct creation of single statement."""
+
+        def _prepare_statement_lines(statements):
+            transact = self.transactions[0]
+            for st_vals in statements[2]:
+                for line_vals in st_vals['transactions']:
+                    line_vals['amount'] = transact['amount']
+                    line_vals['name'] = transact['name']
+                    line_vals['account_number'] = transact['account_number']
+                    line_vals['ref'] = transact['ref']
+
+        testfile = get_module_resource(
+            'account_bank_statement_import_mt940_base',
+            'test_files',
+            'test-rabo.swi',
+        )
+        parser = MT940()
+        parser.header_regex = '^:940:'  # Start of header
+        parser.header_lines = 1  # Number of lines to skip
+        datafile = open(testfile, 'rb').read()
+        statements = parser.parse(datafile)
+
+        _prepare_statement_lines(statements)
+
+        path_addon = 'odoo.addons.account_bank_statement_import.'
+        path_file = 'account_bank_statement_import.'
+        path_class = 'AccountBankStatementImport.'
+        method = path_addon + path_file + path_class + '_parse_file'
+        with patch(method) as my_mock:
+            my_mock.return_value = statements
+
+            action = self.env['account.bank.statement.import'].create({
+                'data_file': base64.b64encode(datafile),
+            }).import_file()
+
+            transact = self.transactions[0]
+            for statement in self.env['account.bank.statement'].browse(
+                action['context']['statement_ids']
+            ):
+                for line in statement.line_ids:
+                    self.assertTrue(
+                        line.bank_account_id.acc_number ==
+                        transact['account_number'])
+                    self.assertTrue(line.amount == transact['amount'])
+                    self.assertTrue(line.date)
+                    self.assertTrue(line.name == transact['name'])
+                    self.assertTrue(line.ref == transact['ref'])