[MIG] partner_contact_job_position: Migration to 12.0

partner_contact_job_position/README.rst

@@ -14,13 +14,13 @@ Partner Job Position
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github
-    :target: https://github.com/OCA/partner-contact/tree/11.0/partner_contact_job_position
+    :target: https://github.com/OCA/partner-contact/tree/12.0/partner_contact_job_position
     :alt: OCA/partner-contact
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-partner_contact_job_position
+    :target: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_job_position
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/134/11.0
+    :target: https://runbot.odoo-community.org/runbot/134/12.0
     :alt: Try me on Runbot
 
 |badge1| |badge2| |badge3| |badge4| |badge5| 
@@ -42,10 +42,6 @@ To configure job positions, you need to:
 
 * Go to *Contacts > Configuration > Job Positions*.
 
-.. figure:: https://raw.githubusercontent.com/OCA/partner-contact/11.0/partner_contact_job_position/path/to/local/image.png
-   :alt: alternative description
-   :width: 600 px
-
 Usage
 =====
 
@@ -60,7 +56,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/partner-contact/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_contact_job_position%0Aversion:%2011.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_contact_job_position%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -75,11 +71,14 @@ Authors
 Contributors
 ~~~~~~~~~~~~
 
-* Pedro M. Baeza <pedro.baeza@tecnativa.com>
 * Antonio Espinosa <antonioea@antiun.com>
-* Rafael Blasco <rafael.blasco@tecnativa.com>
 * Jairo Llopis <yajo.sk8@gmail.com>
-* David Vidal <david.vidal@tecnativa.com>
+* `Tecnativa <https://www.tecnativa.com>`_:
+
+  * Pedro M. Baeza
+  * Rafael Blasco
+  * David Vidal
+  * Ernesto Tejeda
 
 Maintainers
 ~~~~~~~~~~~
@@ -94,6 +93,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/partner-contact <https://github.com/OCA/partner-contact/tree/11.0/partner_contact_job_position>`_ project on GitHub.
+This module is part of the `OCA/partner-contact <https://github.com/OCA/partner-contact/tree/12.0/partner_contact_job_position>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

partner_contact_job_position/__manifest__.py

@@ -7,7 +7,7 @@
 {
     "name": "Partner Job Position",
     "summary": "Categorize job positions for contacts",
-    "version": "11.0.1.0.0",
+    "version": "12.0.1.0.0",
     'category': 'Customer Relationship Management',
     "website": "https://github.com/OCA/partner-contact",
     'author': 'Tecnativa,'

partner_contact_job_position/models/res_partner.py

@@ -11,24 +11,11 @@ class ResPartner(models.Model):
 
     job_position_id = fields.Many2one(
         "res.partner.job_position",
-        "Categorized job position",)
+        "Categorized job position")
 
 
 class ResPartnerJobPosition(models.Model):
     _name = "res.partner.job_position"
-    _order = "parent_left"
-    _parent_order = "name"
-    _parent_store = True
     _description = "Job position"
 
     name = fields.Char(required=True, translate=True)
-    parent_id = fields.Many2one(
-        "res.partner.job_position",
-        "Parent", ondelete='restrict')
-    child_ids = fields.One2many(
-        "res.partner.job_position",
-        "parent_id",
-        "Children",
-        oldname="children")
-    parent_left = fields.Integer(index=True)
-    parent_right = fields.Integer(index=True)

partner_contact_job_position/readme/CONFIGURE.rst

@@ -1,7 +1,3 @@
 To configure job positions, you need to:
 
 * Go to *Contacts > Configuration > Job Positions*.
-
-.. figure:: path/to/local/image.png
-   :alt: alternative description
-   :width: 600 px

partner_contact_job_position/readme/CONTRIBUTORS.rst

@@ -1,5 +1,8 @@
-* Pedro M. Baeza <pedro.baeza@tecnativa.com>
 * Antonio Espinosa <antonioea@antiun.com>
-* Rafael Blasco <rafael.blasco@tecnativa.com>
 * Jairo Llopis <yajo.sk8@gmail.com>
-* David Vidal <david.vidal@tecnativa.com>
+* `Tecnativa <https://www.tecnativa.com>`_:
+
+  * Pedro M. Baeza
+  * Rafael Blasco
+  * David Vidal
+  * Ernesto Tejeda

partner_contact_job_position/security/ir.model.access.csv

@@ -1,5 +1,5 @@
 "id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
 "access_res_partner_job_position_public","res_partner_job_position group_public","model_res_partner_job_position","base.group_public",1,0,0,0
 "access_res_partner_job_position_portal","res_partner_job_position group_portal","model_res_partner_job_position","base.group_portal",1,0,0,0
-"access_res_partner_job_position_group_partner_manager","res_partner_job_position group_partner_manager","model_res_partner_job_position","base.group_partner_manager",1,1,1,1
-"access_res_partner_job_position_group_user","res_partner_job_position group_user","model_res_partner_job_position","base.group_user",1,0,0,0
+"access_res_partner_job_position_partner_manager","res_partner_job_position group_partner_manager","model_res_partner_job_position","base.group_partner_manager",1,1,1,1
+"access_res_partner_job_position_user","res_partner_job_position group_user","model_res_partner_job_position","base.group_user",1,0,0,0

partner_contact_job_position/static/description/index.html

@@ -367,7 +367,27 @@ ul.auto-toc {
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/partner-contact/tree/11.0/partner_contact_job_position"><img alt="OCA/partner-contact" src="https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-partner_contact_job_position"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/134/11.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
+    <p><a class="reference external"
+          href="https://odoo-community.org/page/development-status"><img
+            alt="Beta"
+            src="https://img.shields.io/badge/maturity-Beta-yellow.png"/></a>
+        <a class="reference external"
+           href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img
+                alt="License: AGPL-3"
+                src="https://img.shields.io/badge/licence-AGPL--3-blue.png"/></a>
+        <a class="reference external"
+           href="https://github.com/OCA/partner-contact/tree/12.0/partner_contact_job_position"><img
+                alt="OCA/partner-contact"
+                src="https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github"/></a>
+        <a class="reference external"
+           href="https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_job_position"><img
+                alt="Translate me on Weblate"
+                src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png"/></a>
+        <a class="reference external"
+           href="https://runbot.odoo-community.org/runbot/134/12.0"><img
+                alt="Try me on Runbot"
+                src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png"/></a>
+    </p>
 <p>This module extends the functionality of partners job position to support
 having them categorized in tree form and allow you to choose a categorized job
 position for your contacts in addition to the current custom string for job
@@ -392,9 +412,6 @@ position.</p>
 <ul class="simple">
 <li>Go to <em>Contacts &gt; Configuration &gt; Job Positions</em>.</li>
 </ul>
-<div class="figure">
-<img alt="alternative description" src="https://raw.githubusercontent.com/OCA/partner-contact/11.0/partner_contact_job_position/path/to/local/image.png" style="width: 600px;" />
-</div>
 </div>
 <div class="section" id="usage">
 <h1><a class="toc-backref" href="#id2">Usage</a></h1>
@@ -409,7 +426,9 @@ position.</p>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/partner-contact/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_contact_job_position%0Aversion:%2011.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+    <a class="reference external"
+       href="https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_contact_job_position%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.
+</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -423,11 +442,16 @@ If you spotted it first, help us smashing it by providing a detailed and welcome
 <div class="section" id="contributors">
 <h2><a class="toc-backref" href="#id6">Contributors</a></h2>
 <ul class="simple">
-<li>Pedro M. Baeza &lt;<a class="reference external" href="mailto:pedro.baeza&#64;tecnativa.com">pedro.baeza&#64;tecnativa.com</a>&gt;</li>
 <li>Antonio Espinosa &lt;<a class="reference external" href="mailto:antonioea&#64;antiun.com">antonioea&#64;antiun.com</a>&gt;</li>
-<li>Rafael Blasco &lt;<a class="reference external" href="mailto:rafael.blasco&#64;tecnativa.com">rafael.blasco&#64;tecnativa.com</a>&gt;</li>
 <li>Jairo Llopis &lt;<a class="reference external" href="mailto:yajo.sk8&#64;gmail.com">yajo.sk8&#64;gmail.com</a>&gt;</li>
-<li>David Vidal &lt;<a class="reference external" href="mailto:david.vidal&#64;tecnativa.com">david.vidal&#64;tecnativa.com</a>&gt;</li>
+    <li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:
+        <ul>
+            <li>Pedro M. Baeza</li>
+            <li>Rafael Blasco</li>
+            <li>David Vidal</li>
+            <li>Ernesto Tejeda</li>
+        </ul>
+    </li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -437,7 +461,9 @@ If you spotted it first, help us smashing it by providing a detailed and welcome
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/partner-contact/tree/11.0/partner_contact_job_position">OCA/partner-contact</a> project on GitHub.</p>
+    <p>This module is part of the <a class="reference external"
+                                     href="https://github.com/OCA/partner-contact/tree/12.0/partner_contact_job_position">OCA/partner-contact</a>
+        project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

partner_contact_job_position/views/res_partner_job_position_view.xml

@@ -14,7 +14,6 @@
     <field name="arch" type="xml">
         <tree string="Job positions" editable="top">
             <field name="name"/>
-            <field name="parent_id"/>
         </tree>
     </field>
 </record>
@@ -26,8 +25,6 @@
         <form string="Job positions">
             <group>
                 <field name="name"/>
-                <field name="parent_id"/>
-                <field name="child_ids"/>
             </group>
         </form>
     </field>

partner_contact_job_position/views/res_partner_view.xml

@@ -31,7 +31,7 @@
         </field>
         <filter name="salesperson" position="after">
             <filter string="Job position"
-                    domain="[('is_company','=', True)]"
+                    name="job_position_filter" domain="[('is_company','!=', True)]"
                     context="{'group_by': 'job_position_id'}"/>
         </filter>
     </field>