[FIX] Factorize and clean

super_calendar/models/super_calendar.py

@@ -39,7 +39,7 @@ def _models_get(self):
     return [(model.model, model.name) for model in model_ids]
 
 
-class super_calendar_configurator(models.Model):
+class SuperCalendarConfigurator(models.Model):
     _logger = logging.getLogger(__name__)
     _name = 'super.calendar.configurator'
 
@@ -66,10 +66,16 @@ class super_calendar_configurator(models.Model):
         # Rebuild all calendar records
         for configurator in configurator_ids:
             for line in configurator.line_ids:
+                self._generate_record_from_line(configurator, line)
+        self._logger.info('Calendar generated')
+        return True
+
+    @api.multi
+    def _generate_record_from_line(self, configurator, line):
+        super_calendar_pool = self.env['super.calendar']
         current_pool = self.env[line.name.model]
         domain = line.domain and safe_eval(line.domain) or []
         current_record_ids = current_pool.search(domain)
-
         for cur_rec in current_record_ids:
             f_user = line.user_field_id and line.user_field_id.name
             f_descr = (line.description_field_id and
@@ -132,11 +138,9 @@ class super_calendar_configurator(models.Model):
                     'model_id': line.name.id,
                 }
                 super_calendar_pool.create(super_calendar_values)
-        self._logger.info('Calendar generated')
-        return True
 
 
-class super_calendar_configurator_line(models.Model):
+class SuperCalendarConfiguratorLine(models.Model):
     _name = 'super.calendar.configurator.line'
 
     name = fields.Many2one(
@@ -196,7 +200,7 @@ class super_calendar_configurator_line(models.Model):
     )
 
 
-class super_calendar(models.Model):
+class SuperCalendar(models.Model):
     _name = 'super.calendar'
 
     name = fields.Char(

super_calendar/views/super_calendar_view.xml

@@ -76,7 +76,6 @@
                 <tree string="Calendar">
                     <field name="name"/>
                     <field name="date_start"/>
-                    <!--<field name="date_stop"/>-->
                     <field name="duration"/>
                     <field name="user_id"/>
                     <field name="configurator_id"/>
@@ -95,7 +94,6 @@
                         <group>
                             <field name="name" readonly="1"/>
                             <field name="date_start" readonly="1"/>
-                            <!--<field name="date_stop" readonly="1"/>-->
                             <field name="duration" readonly="1"/>
                             <field name="user_id" readonly="1"/>
                             <field name="configurator_id" readonly="1"/>