[11.0][IMP] base_tier_validation: add tests

base_tier_validation/tests/__init__.py

@@ -0,0 +1,4 @@
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from . import common
+from . import test_tier_validation

base_tier_validation/tests/common.py

@@ -0,0 +1,13 @@
+# Copyright 2018 Eficent Business and IT Consulting Services S.L.
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+
+def setup_test_model(env, model_clses):
+    for model_cls in model_clses:
+        model_cls._build_model(env.registry, env.cr)
+
+    env.registry.setup_models(env.cr)
+    env.registry.init_models(
+        env.cr, [model_cls._name for model_cls in model_clses],
+        dict(env.context, update_custom_fields=True)
+    )

base_tier_validation/tests/test_tier_validation.py

@@ -0,0 +1,150 @@
+# Copyright 2018 Eficent Business and IT Consulting Services S.L.
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
+
+from odoo.tests import common
+from odoo.exceptions import ValidationError, UserError
+from .common import setup_test_model
+from .tier_validation_tester import TierValidationTester
+
+
+@common.at_install(False)
+@common.post_install(True)
+class TierTierValidation(common.SavepointCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super(TierTierValidation, cls).setUpClass()
+
+        setup_test_model(cls.env, [TierValidationTester])
+
+        cls.test_model = cls.env[TierValidationTester._name]
+
+        cls.tester_model = cls.env['ir.model'].search([
+            ('model', '=', 'tier.validation.tester')])
+
+        # Access record:
+        cls.env["ir.model.access"].create({
+            'name': "access.tester",
+            'model_id': cls.tester_model.id,
+            'perm_read': 1,
+            'perm_write': 1,
+            'perm_create': 1,
+            'perm_unlink': 1,
+        })
+
+        # Create users:
+        group_ids = cls.env.ref('base.group_system').ids
+        cls.test_user_1 = cls.env['res.users'].create({
+            'name': 'John',
+            'login': 'test1',
+            'groups_id': [(6, 0, group_ids)],
+        })
+        cls.test_user_2 = cls.env['res.users'].create({
+            'name': 'Mike',
+            'login': 'test2',
+        })
+
+        # Create tier definition:
+        cls.tier_def_obj = cls.env['tier.definition']
+        cls.tier_def_obj.create({
+            'model_id': cls.tester_model.id,
+            'review_type': 'individual',
+            'reviewer_id': cls.test_user_1.id,
+            'python_code': 'rec.test_field > 1.0',
+        })
+
+        cls.test_record = cls.test_model.create({
+            'test_field': 2.5,
+        })
+
+    def test_01_auto_validation(self):
+        """When the user can validate all future reviews, it is not needed
+        to request a validation, the action can be done straight forward."""
+        self.test_record.sudo(self.test_user_1.id).action_confirm()
+        self.assertEqual(self.test_record.state, 'confirmed')
+
+    def test_02_no_auto_validation(self):
+        """User with no right to validate future reviews must request a
+        validation."""
+        with self.assertRaises(ValidationError):
+            self.test_record.sudo(self.test_user_2.id).action_confirm()
+
+    def test_03_request_validation_approved(self):
+        """User 2 request a validation and user 1 approves it."""
+        self.assertFalse(self.test_record.review_ids)
+        reviews = self.test_record.sudo(
+            self.test_user_2.id).request_validation()
+        self.assertTrue(reviews)
+        record = self.test_record.sudo(self.test_user_1.id)
+        record.validate_tier()
+        self.assertTrue(record.validated)
+
+    def test_04_request_validation_rejected(self):
+        """Request validation, rejection and reset."""
+        self.assertFalse(self.test_record.review_ids)
+        reviews = self.test_record.sudo(
+            self.test_user_2.id).request_validation()
+        self.assertTrue(reviews)
+        record = self.test_record.sudo(self.test_user_1.id)
+        record.reject_tier()
+        self.assertTrue(record.review_ids)
+        self.assertTrue(record.rejected)
+        record.restart_validation()
+        self.assertFalse(record.review_ids)
+
+    def test_05_under_validation(self):
+        """Write is forbidden in a record under validation."""
+        self.assertFalse(self.test_record.review_ids)
+        reviews = self.test_record.sudo(
+            self.test_user_2.id).request_validation()
+        self.assertTrue(reviews)
+        record = self.test_record.sudo(self.test_user_1.id)
+        with self.assertRaises(ValidationError):
+            record.write({'test_field': 0.5})
+
+    def test_06_validation_process_open(self):
+        """Operation forbidden while a validation process is open."""
+        self.assertFalse(self.test_record.review_ids)
+        reviews = self.test_record.sudo(
+            self.test_user_2.id).request_validation()
+        self.assertTrue(reviews)
+        record = self.test_record.sudo(self.test_user_1.id)
+        with self.assertRaises(ValidationError):
+            record.action_confirm()
+
+    def test_07_search_reviewers(self):
+        """Test search methods."""
+        reviews = self.test_record.sudo(
+            self.test_user_2.id).request_validation()
+        self.assertTrue(reviews)
+        record = self.test_record.sudo(self.test_user_1.id)
+        self.assertIn(self.test_user_1, record.reviewer_ids)
+        res = self.test_model.search(
+            [('reviewer_ids', 'in', self.test_user_1.id)])
+        self.assertTrue(res)
+
+    def test_08_search_validated(self):
+        """Test for the validated search method."""
+        self.test_record.sudo(self.test_user_2.id).request_validation()
+        res = self.test_model.sudo(self.test_user_1.id).search(
+            [('validated', '=', False)])
+        self.assertTrue(res)
+
+    def test_09_wrong_tier_definition(self):
+        """Error should raise with incorrect python expresions on
+        tier definitions."""
+        self.tier_def_obj.create({
+            'model_id': self.tester_model.id,
+            'review_type': 'individual',
+            'reviewer_id': self.test_user_1.id,
+            'python_code': 'rec.not_existing_field > 1.0',
+        })
+        with self.assertRaises(UserError):
+            self.test_record.sudo(self.test_user_1.id).action_confirm()
+
+    def test_10_dummy_tier_definition(self):
+        """Test tier.definition methods."""
+        res = self.tier_def_obj._get_tier_validation_model_names()
+        self.assertEqual(res, [])
+        res = self.tier_def_obj.onchange_model_id()
+        self.assertTrue(res)

base_tier_validation/tests/tier_validation_tester.py

@@ -0,0 +1,21 @@
+# Copyright 2018 Eficent Business and IT Consulting Services S.L.
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+
+
+class TierValidationTester(models.Model):
+    _name = 'tier.validation.tester'
+    _inherit = ['tier.validation']
+
+    state = fields.Selection(
+        selection=[('draft', 'Draft'),
+                   ('confirmed', 'Confirmed'),
+                   ('cancel', 'Cancel')],
+        default='draft',
+    )
+    test_field = fields.Float()
+
+    @api.multi
+    def action_confirm(self):
+        self.write({'state': 'confirmed'})