Browse Source

[11.0][FIX] Fix CAMT import without NTRY (#163)

pull/167/head
oleksandrpaziuk 6 years ago
committed by Pedro M. Baeza
parent
commit
c1f7c26f6e
  1. 2
      account_bank_statement_import_camt_oca/__manifest__.py
  2. 2
      account_bank_statement_import_camt_oca/models/parser.py
  3. 1
      account_bank_statement_import_camt_oca/test_files/golden-camt053-no-ntry.pydata
  4. 52
      account_bank_statement_import_camt_oca/test_files/test-camt053-no-ntry
  5. 5
      account_bank_statement_import_camt_oca/tests/test_import_bank_statement.py

2
account_bank_statement_import_camt_oca/__manifest__.py

@ -2,7 +2,7 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
{ {
'name': 'CAMT Format Bank Statements Import', 'name': 'CAMT Format Bank Statements Import',
'version': '11.0.1.0.0',
'version': '11.0.1.0.1',
'license': 'AGPL-3', 'license': 'AGPL-3',
'author': 'Odoo Community Association (OCA), Therp BV', 'author': 'Odoo Community Association (OCA), Therp BV',
'website': 'https://github.com/OCA/bank-statement-import', 'website': 'https://github.com/OCA/bank-statement-import',

2
account_bank_statement_import_camt_oca/models/parser.py

@ -181,6 +181,8 @@ class CamtParser(models.AbstractModel):
for entry_node in entry_nodes: for entry_node in entry_nodes:
transactions.extend(self.parse_entry(ns, entry_node)) transactions.extend(self.parse_entry(ns, entry_node))
result['transactions'] = transactions result['transactions'] = transactions
result['date'] = None
if transactions:
result['date'] = sorted(transactions, result['date'] = sorted(transactions,
key=lambda x: x['date'], key=lambda x: x['date'],
reverse=True reverse=True

1
account_bank_statement_import_camt_oca/test_files/golden-camt053-no-ntry.pydata

@ -0,0 +1 @@
(None, None, [])

52
account_bank_statement_import_camt_oca/test_files/test-camt053-no-ntry

@ -0,0 +1,52 @@
<Document xmlns="urn:iso:std:iso:20022:tech:xsd:camt.053.001.04">
<BkToCstmrStmt>
<GrpHdr>
<MsgId>TESTBANK/NL/1420561226673</MsgId>
<CreDtTm>2014-01-06T16:20:26.673Z</CreDtTm>
</GrpHdr>
<Stmt>
<Id>1234Test/1</Id>
<LglSeqNb>2</LglSeqNb>
<CreDtTm>2014-01-06T16:20:26.673Z</CreDtTm>
<FrToDt>
<FrDtTm>2014-01-05T00:00:00.000Z</FrDtTm>
<ToDtTm>2014-01-05T23:59:59.999Z</ToDtTm>
</FrToDt>
<Acct>
<Id>
<IBAN>NL77ABNA0574908765</IBAN>
</Id>
<Nm>Example company</Nm>
<Svcr>
<FinInstnId>
<BIC>ABNANL2A</BIC>
</FinInstnId>
</Svcr>
</Acct>
<Bal>
<Tp>
<CdOrPrtry>
<Cd>OPBD</Cd>
</CdOrPrtry>
</Tp>
<Amt Ccy="CHF">1520.76</Amt>
<CdtDbtInd>CRDT</CdtDbtInd>
<Dt>
<Dt>2014-01-05</Dt>
</Dt>
</Bal>
<Bal>
<Tp>
<CdOrPrtry>
<Cd>CLBD</Cd>
</CdOrPrtry>
</Tp>
<Amt Ccy="CHF">1520.76</Amt>
<CdtDbtInd>CRDT</CdtDbtInd>
<Dt>
<Dt>2014-01-05</Dt>
</Dt>
</Bal>
</Stmt>
</BkToCstmrStmt>
</Document>

5
account_bank_statement_import_camt_oca/tests/test_import_bank_statement.py

@ -57,6 +57,11 @@ class TestParser(TransactionCase):
'test-camt053-txdtls', 'test-camt053-txdtls',
'golden-camt053-txdtls.pydata') 'golden-camt053-txdtls.pydata')
def test_parse_no_ntry(self):
self._do_parse_test(
'test-camt053-no-ntry',
'golden-camt053-no-ntry.pydata')
class TestImport(TransactionCase): class TestImport(TransactionCase):
"""Run test to import camt import.""" """Run test to import camt import."""

Loading…
Cancel
Save