Some little nasty details were overlooked in the v12 migration, which rendered the module basically useless:
- The wizard used to ask for consent in manual activities did not fill the placeholders, resulting in an awkward UX.
- The sent mails **did not have the token** to authenticate and actually allow accepting or rejecting. These buttons returned a 500 error.
- Once the token is added, the form was ugly.
- Sadly, some tests were testing the how and not the what. It is understandable due to the complexity of testing the what, even more without the `Form` utility, new on v12. These are fixed now too.
@Tecnativa TT25868
Due to a bug present in the `_postprocess_sent_message` code, if a consent wasn't successfully sent, still the consent got marked as sent.
It should stay as draft. Modify tests to test this new behavior.
@Tecnativa TT24457
new file: website_contact_extend/README.rst
new file: website_contact_extend/__init__.py
new file: website_contact_extend/__manifest__.py
new file: website_contact_extend/controllers/__init__.py
new file: website_contact_extend/controllers/contactby.py
new file: website_contact_extend/controllers/myfilter.py
new file: website_contact_extend/data/email_templates.xml
new file: website_contact_extend/i18n/de.po
new file: website_contact_extend/i18n/en_US.po
new file: website_contact_extend/models/__init__.py
new file: website_contact_extend/models/res_partner.py
new file: website_contact_extend/readme/CONFIGURE.rst
new file: website_contact_extend/readme/DESCRIPTION.rst
new file: website_contact_extend/readme/USAGE.rst
new file: website_contact_extend/static/description/icon.png
new file: website_contact_extend/static/description/index.html
new file: website_contact_extend/static/src/js/contactus.js
new file: website_contact_extend/views/contact_report.xml
new file: website_contact_extend/views/disp_msg_template.xml
new file: website_contact_extend/views/email_template.xml
new file: website_contact_extend/views/means_of_contact.xml
new file: website_contact_extend/views/res_partner.xml
new file: website_contact_extend/views/website_contact.xml
Changes to be committed:
new file: contact_search_form/README.rst
new file: contact_search_form/__init__.py
new file: contact_search_form/__manifest__.py
new file: contact_search_form/i18n/de.po
new file: contact_search_form/i18n/en_US.po
new file: contact_search_form/models/__init__.py
new file: contact_search_form/models/contact_search.py
new file: contact_search_form/readme/CONFIGURE.rst
new file: contact_search_form/readme/DESCRIPTION.rst
new file: contact_search_form/readme/USAGE.rst
new file: contact_search_form/security/gdpr_security.xml
new file: contact_search_form/security/ir.model.access.csv
new file: contact_search_form/static/description/icon.png
new file: contact_search_form/static/description/index.html
new file: contact_search_form/views/contact_search.xml
- Partner's `opt_out` no longer exists. Using `mail.blacklist` now.
- Tests updated to support that change.
- Test workarounds removed.
- Duplicated-field-name-in-model warning removed.
- Use create multi where possible.
Before https://github.com/OCA/data-protection/pull/29 there was a race condition where an email could be sent while the same transaction that created the `privacy.consent` record still wasn't committed, producing a 404 error if the user clicked on "Accept" or "Reject" before all mails were sent.
To avoid that, a raw `cr.commit()` was issued, but this produced another situation where the user had to wait until the full email queue is cleared to get his page loaded. It wasn't an error, but a long queue meant several minutes waiting, and it's ulikely that an average human is so patient.
So, here's the final fix (I hope!). The main problem was that I was looking in the wrong place to send the email. It turns out that the `self.post_message_with_template()` method is absolutely helpless in the case at hand, where these criteria must be met:
* E-mail must be enqueued, no matter if there are less or more than 50 consents to send.
* The template must be processed per record.
* In an ideal world, a `cr.commit()` must be issued after each sent mail.
The metod that was being used:
* Didn't allow to use `auto_commit` mode.
* Only allowed to render the template per record if called with `composition_mode="mass_mail"`.
* Only allowed to enqueue emails if called with `composition_mode="mass_post"`.
Obviously, I cannot set 2 different values for `composition_mode`, so a different strategy had to be used.
I discovered that the `mail.template` model has a helpful method called `send_mail()` that, by default:
* Renders the template per record
* Enqueues the email
* The email queue is cleared in `auto_commit=True` mode.
So, from now on, problems are gone:
* The user click, or the cron run, will just generate the missing `privacy.consent` records and enqueue mails for them.
* The mail queue manager will send them later, in `auto_commit` mode.
* After sending the e-mail, this module will set the `privacy.consent` record as `sent`.
* Thanks to *not* sending the email, the process the user faces when he hits the "generate" button is faster.
* Instructions in the README and text in the "generate" button are updated to reflect this new behavior.
* Thanks to the `auto_commit` feature, if Odoo is rebooted in the middle of a mail queue clearance, the records that were sent remain properly marked as sent, and the missing mails will be sent after the next boot.
* No hardcoded commits.
* No locked transactions.
* BTW I discovered that 2 different emails were created when creating a new consent. I started using `mail_create_nolog=True` to avoid that problem and only log a single creation message.
Note to self: never use again `post_message_with_template()`.
It could happen that, while Odoo is still sending emails, a subject receives it and clicks on accept/reject links.
In such case, he'd get a 404 error because the record wouldn't exist yet in the database. That's because the DB commit was made only after processing all the sent emails.
We need to commit in advance to make sure that doesn't happen.
IT IS AG
OCA-git-bot
Víctor Martínez
David Vidal
sergiocorato
Jarmo Kortetjärvi
Bosd
Jairo Llopis
OCA Transbot
oca-travis
Nicolas JEUDY
Bole
Christopher Lorenz
Jairo Llopis
Jairo Llopis
fkantelberg
dw3gn3r