The goal of the modified method is to create or remove the relationship
(in the M2m relation tabel) between the tested model (such as
sale_order) and the exception rules. When the ORM writes on
ExceptionRule.sale_ids (using the example of sale_exception), it will
first proceeds with these updates:
* an UPDATE on exception_rule to set the write_date
* INSERT or DELETE on the relation table
* but then, as "write" is called on the exception rule, the ORM will
trigger the api.depends to recompute all the "main_exception_ids"
of the records (sales, ...) related to it, leading to an UPDATE
for each sale order
We end up with RowExclusiveLock on such records:
* All the records of the relation table added / deleted for the current
sale order
* All the records of exception_rule matching the current sale order
* All the records of sale_order related to the exception rules matching
the current sale order
The first one is expected, the next 2 are not. We can remove the lock on
the exception_rule table by removing `_log_access`, however in any case,
the main_exception_ids computed field will continue to lock many sale
orders, effectively preventing 2 sales orders with the same exception
to be confirmed at the same time.
Reversing the write by writing on SaleOrder instead of ExceptionRule
fixes the 2 unexpected locks. It should not result in more queries: the
"to remove" part generates a DELETE on the relation table for the rule
to remove and the "to add" part generates an INSERT for the rule to add,
both will be exactly the same in both cases.
Related to #1642
Replaces #1638
In the documentation.
The method called by '_check_exception' has a side effect, it writes
on 'exception.rule' + on the Many2many relation between it and
the related model (such as sale.order). When decorated by
@api.constrains, any error during the method will be caught and
re-raised as "ValidationError". This part of code is very prone to
concurrent updates as 2 sales having the same exception will both write
on the same 'exception.rule'. A concurrent update (OperationalError) is
re-raised as ValidationError, and then is not retried properly.
Calling the same method in create/write has the same effect than
@api.constrains without shadowing the exception type.
Full explanation:
OCA/server-tools#1642
Current method doesn't work, as this module is not being migrated, but
fresh-installed by dependencies of old `sale_exception`, so we should use
the pre_init_hook and detect if we should run the migration code according the
existence of the table.
OCA Transbot
OCA-git-bot
oca-travis
Denis Roussel
Guewen Baconnier
hparfr
Florian da Costa
Florent THOMAS
Mourad EL HADJ MIMOUNE
Pedro M. Baeza
David Beal
Cédric Pigeon
Stéphane Bidoul (ACSONE)